Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file.

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to header file.
Date	2016-01-29 07:40 +0100
Message-ID	<qWaSR-7bs-3@gated-at.bofh.it> (permalink)
References	<qDk6m-79U-3@gated-at.bofh.it> <qDqbM-2Nk-27@gated-at.bofh.it> <qFP62-7p3-19@gated-at.bofh.it> <qGB10-4zr-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 17, 2015 at 12:46:14PM +0530, Sudip Mukherjee wrote:
> On Mon, Dec 14, 2015 at 07:08:08PM -0500, Sanidhya Solanki wrote:
> > The original code defined macros in the source code, making it
> > harder to read. Moved them to the header file, as per the TODO file.
> > 
> > Updated the TODO file.
> 
> I think the TODO file should not be updated now. There are still some
> macros in skein_block.c.

I agree, it can't be removed just yet, this patch needs to be redone
before I can take it.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] Staging: Skein: Moved macros from skein_block.c to  header file. Greg KH <gregkh@linuxfoundation.org> - 2016-01-29 07:40 +0100

csiph-web