Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver
Date	2016-01-30 23:00 +0100
Message-ID	<qWLIK-1AZ-27@gated-at.bofh.it> (permalink)
References	<qLe3M-8ln-11@gated-at.bofh.it> <qLUFH-2le-5@gated-at.bofh.it> <qWlY0-79P-69@gated-at.bofh.it> <qWnGq-8t5-11@gated-at.bofh.it> <qWnZM-aN-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 29, 2016 at 2:38 PM, Timur Tabi <timur@codeaurora.org> wrote:
> Rob Herring wrote:

[...]

>>>> Isn't this a user enabled feature if the h/w supports it?
>>>
>>>
>>>
>>> Is there a sysfs entry for that?  We were planning on having a similar
>>> ACPI
>>> property.
>>
>>
>> It would be in ethtool I think.
>
>
> Ah, this driver does not support ethtool yet.
>
> However, based on a cursory look of ethtool, it appears that there's only an
> option to query the current timestamp, but not actually enable/disable the
> feature.  The e1000e driver, for example, just forces the feature by default
> for various chips.  Is there any reason why we shouldn't enable it if the
> hardware supports it?

Probably not. You simply ignore the timestamp if you don't care. So
then why do you want a DT property?

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver Timur Tabi <timur@codeaurora.org> - 2016-01-29 19:30 +0100
  Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver Rob Herring <robh@kernel.org> - 2016-01-29 21:20 +0100
    Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver Timur Tabi <timur@codeaurora.org> - 2016-01-29 21:40 +0100
      Re: [PATCH V3] net: emac: emac gigabit ethernet controller driver Rob Herring <robh@kernel.org> - 2016-01-30 23:00 +0100

csiph-web