Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1322492

[PATCH 1/3] libnvdimm: fix mode determination for e820 devices

From Dan Williams <dan.j.williams@intel.com>
Newsgroups linux.kernel
Subject [PATCH 1/3] libnvdimm: fix mode determination for e820 devices
Date 2016-01-30 19:50 +0100
Message-ID <qWIKR-81s-7@gated-at.bofh.it> (permalink)
References <qWIKR-81s-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Correctly display "safe" mode when a btt is established on a e820/memmap
defined pmem namespace.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/nvdimm/namespace_devs.c |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index 8ebfcaae3f5a..9edf7eb7d17c 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -1277,10 +1277,12 @@ static ssize_t mode_show(struct device *dev,
 
 	device_lock(dev);
 	claim = ndns->claim;
-	if (pmem_should_map_pages(dev) || (claim && is_nd_pfn(claim)))
-		mode = "memory";
-	else if (claim && is_nd_btt(claim))
+	if (claim && is_nd_btt(claim))
 		mode = "safe";
+	else if (claim && is_nd_pfn(claim))
+		mode = "memory";
+	else if (!claim && pmem_should_map_pages(dev))
+		mode = "memory";
 	else
 		mode = "raw";
 	rc = sprintf(buf, "%s\n", mode);

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] libnvdimm: fix memmap in pmem support Dan Williams <dan.j.williams@intel.com> - 2016-01-30 19:50 +0100
  [PATCH 2/3] libnvdimm, pfn: fix restoring memmap location Dan Williams <dan.j.williams@intel.com> - 2016-01-30 19:50 +0100
  [PATCH 1/3] libnvdimm: fix mode determination for e820 devices Dan Williams <dan.j.williams@intel.com> - 2016-01-30 19:50 +0100
  [PATCH 3/3] devm_memremap_pages: fix vmem_altmap lifetime +  alignment handling Dan Williams <dan.j.williams@intel.com> - 2016-01-30 19:50 +0100

csiph-web