Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1322433

[PATCH v3 3/6] libertas: do not confirm sleep if commands are pending

From Andreas Kemnade <andreas@kemnade.info>
Newsgroups linux.kernel
Subject [PATCH v3 3/6] libertas: do not confirm sleep if commands are pending
Date 2016-01-30 18:10 +0100
Message-ID <qWHc7-70c-33@gated-at.bofh.it> (permalink)
References <qWHc6-70c-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


If the main thread gets one PS AWAKE event and one PS SLEEP event
in one iteration over event_fifo there will never be checks for
commands to be processed, since psstate will always be
PS_STATE_SLEEP or PS_STATE_PRE_SLEEP

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
changes in v3: corrected paths
changes in v2: reordered: was 4/6
 drivers/net/wireless/marvell/libertas/cmdresp.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/libertas/cmdresp.c
index 701125f..c95bf6d 100644
--- a/drivers/net/wireless/marvell/libertas/cmdresp.c
+++ b/drivers/net/wireless/marvell/libertas/cmdresp.c
@@ -257,6 +257,10 @@ int lbs_process_event(struct lbs_private *priv, u32 event)
 			       "EVENT: in FULL POWER mode, ignoring PS_SLEEP\n");
 			break;
 		}
+		if (!list_empty(&priv->cmdpendingq)) {
+			lbs_deb_cmd("EVENT: commands in queue, do not sleep\n");
+			break;
+		}
 		priv->psstate = PS_STATE_PRE_SLEEP;
 
 		lbs_ps_confirm_sleep(priv);
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH v3 3/6] libertas: do not confirm sleep if commands are pending Andreas Kemnade <andreas@kemnade.info> - 2016-01-30 18:10 +0100

csiph-web