Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322470

Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types

Show all headers | View raw

On Sat, 2016-01-30 at 12:05 -0200, Lucas Tanure wrote:
> On Sat, Jan 30, 2016 at 11:45 AM, Patrick McHardy <kaber@trash.net> wrote:
> > On 30.01, Lucas Tanure wrote:
> >> As suggested by checkpatch.pl:
> >> CHECK: Prefer kernel type 'uX' over 'uintX_t'
> >
> > You might have noticed we have literally hundreds of them spread over 100
> > files in the netfilter code. We'll gradually change them when the code is
> > touched anyways.
> >
> >>  net/ipv4/netfilter/ip_tables.c | 5 ++---
> >>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Yes, I checked that. But would be better to change that now?
> Because:
> - could take years to anyone to touch the code, as the code already
> works very well
> - be more standardized could facilitate reading the code
> - It's a good way to encourage new people to contribute to the code
> 
> Thanks!

These changes are a pain for people having to constantly backport fixes
into stable kernels, or rebase their patches before upstream
submissions.

Things like 'git cherry-pick' , 'git rebase' no longer work.
This is a huge pain, and manual editing to resolve conflicts often
add bugs.

Really, do you believe the 'uX' over 'uintX_t' stuff really matters for
people working on adding new features and fixing bugs ?

I am certain that if you had to work like us, you would quickly see the
utility of such changes is negative.

Sure, new submissions should be clean, but 'fixing' old code is not
worth it.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] netfilter: ipv4: use preferred kernel types Lucas Tanure <tanure@linux.com> - 2016-01-30 14:20 +0100
  Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Patrick McHardy <kaber@trash.net> - 2016-01-30 14:50 +0100
    Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Lucas Tanure <tanure@linux.com> - 2016-01-30 15:10 +0100
      Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Joe Perches <joe@perches.com> - 2016-01-30 18:30 +0100
      Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-30 19:00 +0100
        Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Joe Perches <joe@perches.com> - 2016-01-30 19:30 +0100
          Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Lucas Tanure <tanure@linux.com> - 2016-01-30 19:50 +0100
  RE: [PATCH 3/4] netfilter: ipv4: use preferred kernel types David Laight <David.Laight@ACULAB.COM> - 2016-02-01 17:50 +0100
    Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types David Miller <davem@davemloft.net> - 2016-02-01 20:50 +0100
      Re: [PATCH 3/4] netfilter: ipv4: use preferred kernel types Tom Herbert <tom@herbertland.com> - 2016-02-01 21:10 +0100

csiph-web