Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322401

Re: [PATCH] clk: axi-clkgen: Remove sometimes impossible check

Show all headers | View raw

On 01/30/2016 02:13 AM, Stephen Boyd wrote:
> The size of unsigned long on 64-bit architectures is equal to the
> size of u64, so this check is impossible there. This throws off
> static checkers:
> 
> drivers/clk/clk-axi-clkgen.c:331 axi_clkgen_recalc_rate() warn:
> impossible condition '(tmp > (~0)) => (0-u64max > u64max)'
> 
> Let's change this code to use min_t() instead so that we
> get the same effect on architectures where sizeof(unsigned long)
> doesn't equal sizeof(u64).
> 
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Thanks.

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clk: axi-clkgen: Remove sometimes impossible check Stephen Boyd <sboyd@codeaurora.org> - 2016-01-30 02:20 +0100
  Re: [PATCH] clk: axi-clkgen: Remove sometimes impossible check Lars-Peter Clausen <lars@metafoo.de> - 2016-01-30 17:10 +0100

csiph-web