Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322299

Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32

From Ingo Molnar <mingo@kernel.org>
Newsgroups linux.kernel
Subject Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32
Date 2016-01-30 10:40 +0100
Message-ID <qWAaB-Eg-1@gated-at.bofh.it> (permalink)
References <qW414-2cO-23@gated-at.bofh.it> <qWfzd-2gW-41@gated-at.bofh.it> <qWoMb-IK-33@gated-at.bofh.it> <qWpyy-1lv-17@gated-at.bofh.it> <qWpId-1q3-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

* Andy Lutomirski <luto@amacapital.net> wrote:

> >>>+      if [ "$abi" == "COMMON" -o "$abi" == "64" ]; then
> >>>+          # COMMON is the same as 64, except that we don't expect X32
> >>>+          # programs to use it.  Our expectation has nothing to do with
> >>>+          # any generated code, so treat them the same.
> >>>+          emit 64 "$nr" "$entry" "$compat"
> >>>+      elif [ "$abi" == "X32" ]; then
> >>>+          # X32 is equivalent to 64 on an X32-compatible kernel.
> >>>+          echo "#ifdef CONFIG_X86_X32_ABI"
> >>>+          emit 64 "$nr" "$entry" "$compat"
> >>>+          echo "#endif"
> >>>+      elif [ "$abi" == "I386" ]; then
> >>>+          emit "$abi" "$nr" "$entry" "$compat"
> >>>+      else
> >>>+          echo "Unknown abi $abi" >&2
> >>>+          exit 1
> >>>+      fi

> No combinatorial explosion, please.  We could use __SYSCALL(nr, sym,
> abi, qual), though.

Mind fixing it, so that we get back the arch-neutral property?

Thanks,

	Ingo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 04/10] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32 Andy Lutomirski <luto@kernel.org> - 2016-01-29 00:20 +0100
  [tip:x86/asm] x86/syscalls:   Remove __SYSCALL_COMMON and __SYSCALL_X32 tip-bot for Andy Lutomirski <tipbot@zytor.com> - 2016-01-29 12:40 +0100
    Re: [tip:x86/asm] x86/syscalls:  Remove __SYSCALL_COMMON and __SYSCALL_X32 "H. Peter Anvin" <hpa@zytor.com> - 2016-01-29 22:30 +0100
      Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32 Brian Gerst <brgerst@gmail.com> - 2016-01-29 23:20 +0100
        Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32 Andy Lutomirski <luto@amacapital.net> - 2016-01-29 23:30 +0100
          Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and  __SYSCALL_X32 Ingo Molnar <mingo@kernel.org> - 2016-01-30 10:40 +0100
            Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32 Andy Lutomirski <luto@amacapital.net> - 2016-01-30 18:40 +0100
              Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32 "H. Peter Anvin" <hpa@zytor.com> - 2016-01-30 22:30 +0100
        Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32 "H. Peter Anvin" <hpa@zytor.com> - 2016-01-30 19:50 +0100

csiph-web