Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny unaligned packets.

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny unaligned packets.
Date	2016-01-29 01:10 +0100
Message-ID	<qW4Ns-2NZ-3@gated-at.bofh.it> (permalink)
References	<qVdzs-5Vw-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Nicolas Schichan <nschichan@freebox.fr>
Date: Tue, 26 Jan 2016 16:12:35 +0100

> The code in txq_put_data() would use txq->tx_curr_desc to index the
> tso_hdrs/tso_hdrs_dma buffers, for less than 8 bytes unaligned
> fragments, which is already moved to the next descriptor at the
> beginning of the function.
> 
> If that fragment was the last of the the skb, the next skb would use
> that same space to place the ip headers, overwritting that small
> fragment data.
> 
> Fixes: 91986fd3d335 (net: mv643xx_eth: Ensure proper data alignment in TSO TX path)
> Signed-off-by: Nicolas Schichan <nschichan@freebox.fr>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and  tiny unaligned packets. David Miller <davem@davemloft.net> - 2016-01-29 01:10 +0100

csiph-web