Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321069

Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny unaligned packets.

Show all headers | View raw

Am 26.01.2016 um 16:12 schrieb Nicolas Schichan:
> The code in txq_put_data() would use txq->tx_curr_desc to index the
> tso_hdrs/tso_hdrs_dma buffers, for less than 8 bytes unaligned
> fragments, which is already moved to the next descriptor at the
> beginning of the function.
>
> If that fragment was the last of the the skb, the next skb would use
> that same space to place the ip headers, overwritting that small
> fragment data.
>
> Fixes: 91986fd3d335 (net: mv643xx_eth: Ensure proper data alignment in TSO TX path)
> Signed-off-by: Nicolas Schichan <nschichan@freebox.fr>

Hello Nicolas,

thanks for catching this bug. Fix is good.

Reviewed-by: Philipp Kirchhofer <philipp@familie-kirchhofer.de>

Best wishes,
   Philipp

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] net: mv643xx_eth: fix packet corruption with TSO and tiny  unaligned packets. Philipp Kirchhofer <philipp@familie-kirchhofer.de> - 2016-01-28 22:30 +0100

csiph-web