Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320952

RE: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot

Show all headers | View raw

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@aepfle.de]
> Sent: Thursday, January 28, 2016 7:56 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; ohering@suse.com;
> jbottomley@parallels.com; hch@infradead.org; linux-scsi@vger.kernel.org;
> apw@canonical.com; vkuznets@redhat.com; jasowang@redhat.com;
> martin.petersen@oracle.com; hare@suse.de
> Subject: Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test
> robot
> 
> On Wed, Jan 27, K. Y. Srinivasan wrote:
> 
> > +	depends on SCSI_FC_ATTRS
> 
> I think 'depends' instead of 'select' will cause HYPERV_STORAGE to
> disapepar during make oldconfig if SCSI_FC_ATTRS was not set before.
> Not sure what the policy of 'depends' vs.  'select' actually is.  If
> SCSI_FC_ATTRS is supposed to be a library kind of thing then 'select'
> might be the correct way.

The current build issue is because the Hyper-V storage is configured to be built with
the kernel while the SCSI_FC_AATRS is configured as a module. This patch fixes that issue.
I too am not sure what the policy of using "depends" vs " select" is.
James, what would be your recommendation here.

Regards,

K. Y
> 
> Olaf

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild test robot "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 07:00 +0100
  Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild  test robot James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-28 07:10 +0100
    RE: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild  test robot KY Srinivasan <kys@microsoft.com> - 2016-01-28 16:50 +0100
  Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild  test robot Olaf Hering <olaf@aepfle.de> - 2016-01-28 17:00 +0100
    RE: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild  test robot KY Srinivasan <kys@microsoft.com> - 2016-01-28 20:10 +0100
      Re: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild  test robot James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-01-28 20:30 +0100
        RE: [PATCH 1/1] scsi: storvsc: Fix a build issue reported by kbuild  test robot KY Srinivasan <kys@microsoft.com> - 2016-01-28 20:30 +0100

csiph-web