Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1318995

Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks

From "Michael S. Tsirkin" <mst@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks
Date 2016-01-27 15:20 +0100
Message-ID <qVz6V-4J4-1@gated-at.bofh.it> (permalink)
References (1 earlier) <qQfBT-7kg-5@gated-at.bofh.it> <qV7aG-1qe-7@gated-at.bofh.it> <qVjvc-1Q5-11@gated-at.bofh.it> <qVyXg-4EQ-7@gated-at.bofh.it> <qVz6V-4J4-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jan 27, 2016 at 03:14:09PM +0100, Peter Zijlstra wrote:
> On Wed, Jan 27, 2016 at 04:07:56PM +0200, Michael S. Tsirkin wrote:
> > mwait_idle is the only one that calls smp_mb and not mb()
> > I couldn't figure out why - original patches did mb()
> > there.
> 
> That probably wants changing. That said, running UP kernels on affected
> hardware is 'unlikely' :-)

OK that's nice. After changing that one place, everyone calls
mb() around clflush so it should be safe to change smp_mb away
from mfence without breaking things.
I'm testing v4 that does this.

-- 
MST

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-26 09:30 +0100
  Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks "H. Peter Anvin" <hpa@zytor.com> - 2016-01-26 22:40 +0100
    Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-27 15:10 +0100
      Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-27 15:20 +0100
      Re: [PATCH v2 0/3] x86: faster mb()+other barrier.h tweaks Peter Zijlstra <peterz@infradead.org> - 2016-01-27 15:20 +0100

csiph-web