Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318983

Re: [PATCH] drivers/pinctrl: make mediatek/pinctrl-mt8* driver explicitly non-modular

Show all headers | View raw

On Mon, Jan 4, 2016 at 6:44 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:

> The Kconfig for these drivers are currently:
>
> config PINCTRL_MT8127
>         bool "Mediatek MT8127 pin control" if COMPILE_TEST && !MACH_MT8127
>
> config PINCTRL_MT8135
>         bool "Mediatek MT8135 pin control" if COMPILE_TEST && !MACH_MT8135
>
> config PINCTRL_MT8173
>         bool "Mediatek MT8173 pin control"
>
> ...meaning that they are currently not being built as a module by anyone.
> Lets remove the modular code that is essentially orphaned, so that
> when reading the driver there is no doubt it is builtin-only.
>
> A recent commit moved these from module_init to arch_initcall already, so
> the init ordering remains untouched with this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Daniel Kurtz <djkurtz@chromium.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: Hongzhou Yang <hongzhou.yang@mediatek.com>
> Cc: Yingjoe Chen <yingjoe.chen@mediatek.com>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

Patch applied.

Sorry for delayed response...

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] drivers/pinctrl: make mediatek/pinctrl-mt8* driver  explicitly non-modular Linus Walleij <linus.walleij@linaro.org> - 2016-01-27 15:10 +0100

csiph-web