[PATCH] tools build: Check basic headers for test-compile feature checker

From	Wang Nan <wangnan0@huawei.com>
Newsgroups	linux.kernel
Subject	[PATCH] tools build: Check basic headers for test-compile feature checker
Date	2016-01-27 12:30 +0100
Message-ID	<qVwsq-2JC-9@gated-at.bofh.it> (permalink)
References	<qVf8e-6St-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

An i386 binary can be linked correctly even without correct headers.
Which causes problem. For exmaple:

 $ mv /tmp/oxygen_root/usr/include/gnu/stubs-32.h{,.bak}
 $ make tools/perf
 Auto-detecting system features:
 ...                         dwarf: [ on  ]
 [SNIP]
   GEN      common-cmds.h
   CC       perf-read-vdso32
 In file included from /tmp/oxygen_root/usr/include/features.h:388:0,
                  from /tmp/oxygen_root/usr/include/stdio.h:27,
                  from perf-read-vdso.c:1:
 /tmp/oxygen_root/usr/include/gnu/stubs.h:7:27: fatal error: gnu/stubs-32.h: No such file or directory
  # include <gnu/stubs-32.h>
                           ^
 compilation terminated.
 ...

In this patch we checks not only compiler and linker, but also basic
headers in test-compile test case, make it fail on a platform
lacking correct headers.

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Li Zefan <lizefan@huawei.com>
---
 tools/build/feature/test-compile.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/build/feature/test-compile.c b/tools/build/feature/test-compile.c
index 31dbf45..c54e655 100644
--- a/tools/build/feature/test-compile.c
+++ b/tools/build/feature/test-compile.c
@@ -1,4 +1,6 @@
+#include <stdio.h>
 int main(void)
 {
+	printf("Hello World!\n");
 	return 0;
 }
-- 
1.8.3.4

Thread

[GIT PULL 00/54] perf tools: Bugfix, BPF improvements and overwrite ring buffer support Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 16/54] perf tools: Introduce bpf-output event Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 20/54] perf core: Prepare writing into ring buffer from end Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 33/54] perf record: Add '--timestamp-filename' option to append timestamp to output filename Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 25/54] perf tools: Print write_backward value in perf_event_attr__fprintf Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 03/54] tools build: Allow subprojects select all feature checkers Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 28/54] perf record: Extract synthesize code to record__synthesize() Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 23/54] perf tools: Introduce API to pause ring buffer Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 39/54] perf record: Ensure return non-zero rc when mmap fail Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 14/54] perf tools: Support setting different slots in a BPF map separately Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 19/54] perf core: Set event's default overflow_handler Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 06/54] perf test: Check environment before start real BPF test Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 13/54] perf tools: Support perf event alias name Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:00 +0100
  [PATCH 42/54] perf tools: Automatically add new channel according to evlist Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 40/54] perf record: Prevent reading invalid data in record__mmap_read Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 24/54] perf tools: Only validate is_pos for tracking evsels Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 36/54] perf record: Disable buildid cache options by default in switch output mode Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 26/54] perf tools: Move timestamp creation to util Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 38/54] perf record: Generate tracking events for process forked by perf Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 32/54] perf record: Use OPT_BOOLEAN_SET for buildid cache related options Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 34/54] perf record: Split output into multiple files via '--switch-output' Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 30/54] perf record: Turns auxtrace_snapshot_enable into 3 states Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 35/54] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 49/54] perf tools: Set write_backward attribut bit for overwrite events Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 45/54] perf record: Don't read from and poll overwrite channel Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 15/54] perf tools: Enable indices setting syntax for BPF maps Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 22/54] perf core: Reduce perf event output overhead by new overflow handler Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 50/54] perf record: Toggle overwrite ring buffer for reading Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
    Re: [PATCH 50/54] perf record: Toggle overwrite ring buffer for reading "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-26 09:30 +0100
  [PATCH 37/54] perf record: Re-synthesize tracking events after output switching Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 17/54] perf data: Support converting data from bpf_perf_event_output() Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 31/54] perf record: Introduce record__finish_output() to finish a perf.data Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 29/54] perf tools: Add perf_data_file__switch() helper Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 54/54] perf tools: Don't warn about out of order event if write_backward is used Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 27/54] perf tools: Make ordered_events reusable Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 11/54] perf record: Apply config to BPF objects before recording Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:10 +0100
  [PATCH 18/54] perf core: Introduce new ioctl options to pause and resume ring buffer Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 12/54] perf tools: Enable passing event to BPF object Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 52/54] perf record: Read from backward ring buffer Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 47/54] perf tools: Detect avalibility of write_backward Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 10/54] perf tools: Enable BPF object configure syntax Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 41/54] perf tools: Add evlist channel helpers Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 01/54] perf test: Add libbpf relocation checker Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
    Re: [PATCH 01/54] perf test: Add libbpf relocation checker Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-26 16:00 +0100
      Re: [PATCH 01/54] perf test: Add libbpf relocation checker Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-26 16:10 +0100
  [PATCH 08/54] perf test: Improve bp_signal Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 44/54] perf tools: Squash overwrite setting into channel Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 05/54] perf build: Use feature dump file for build-test Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
    Re: [PATCH 05/54] perf build: Use feature dump file for build-test Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-26 18:00 +0100
      Re: [PATCH 05/54] perf build: Use feature dump file for build-test "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-27 03:40 +0100
        Re: [PATCH 05/54] perf build: Use feature dump file for build-test Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-27 15:00 +0100
      [PATCH] tools build: Check basic headers for test-compile feature checker Wang Nan <wangnan0@huawei.com> - 2016-01-27 12:30 +0100
        Re: [PATCH] tools build: Check basic headers for test-compile  feature checker Jiri Olsa <jolsa@redhat.com> - 2016-01-27 14:30 +0100
          Re: [PATCH] tools build: Check basic headers for test-compile  feature checker Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-27 15:00 +0100
  [PATCH 51/54] perf record: Rename variable to make code clear Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 09/54] perf tools: Add API to config maps in bpf object Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 48/54] perf tools: Enable overwrite settings Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 02/54] perf bpf: Check relocation target section Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 21/54] perf core: Add backward attribute to perf event Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 04/54] perf build: Select all feature checkers for feature-dump Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 43/54] perf tools: Operate multiple channels Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 46/54] perf record: Don't poll on overwrite channel Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [PATCH 07/54] perf tools: Fix symbols searching for offline module in buildid-cache Wang Nan <wangnan0@huawei.com> - 2016-01-25 11:20 +0100
  [offlist] Re: [GIT PULL 00/54] perf tools: Bugfix, BPF improvements  and overwrite ring buffer support "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-26 10:20 +0100
    Re: [offlist] Re: [GIT PULL 00/54] perf tools: Bugfix, BPF  improvements and overwrite ring buffer support Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-26 15:20 +0100

csiph-web