Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318846
| From | Johannes Berg <johannes@sipsolutions.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon |
| Date | 2016-01-27 11:50 +0100 |
| Message-ID | <qVvPI-2dw-17@gated-at.bofh.it> (permalink) |
| References | <qVkAW-2yI-17@gated-at.bofh.it> <qVkAW-2yI-15@gated-at.bofh.it> <qVl3Y-2ZP-19@gated-at.bofh.it> <qVvG2-2ab-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2016-01-27 at 11:33 +0100, Jonas Gorski wrote:
>
> > +++ b/arch/mips/boot/dts/brcm/bcm6368.dtsi
> > @@ -54,7 +54,7 @@
> > periph_cntl: syscon@10000000 {
> > compatible = "syscon";
> > reg = <0x10000000 0x14>;
> > - little-endian;
> > + native-endian;
>
> But native-endian == big-endian usually for bcm63xx, so is this
> actually a bugfix?
>
It's complicated :)
These were originally specified as little-endian because it _worked_,
but that was only because of an issue with the code - it was getting
byteswapped twice.
This was "fixed" in commit 29bb45f25ff3051354ed330c0d0f10418a2b8c7c,
and I assume this DT file was created/copied before that commit and
didn't get that update due to merge delays. So after that commit, this
file couldn't have worked, but that's how it got to this point.
johannes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Mark Brown <broonie@kernel.org> - 2016-01-26 23:50 +0100
Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Florian Fainelli <f.fainelli@gmail.com> - 2016-01-27 00:20 +0100
Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Ralf Baechle <ralf@linux-mips.org> - 2016-01-27 10:40 +0100
Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Jonas Gorski <jogo@openwrt.org> - 2016-01-27 11:40 +0100
Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Johannes Berg <johannes@sipsolutions.net> - 2016-01-27 11:50 +0100
Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Mark Brown <broonie@kernel.org> - 2016-01-27 12:20 +0100
Re: [PATCH RFC 2/2] MIPS: dt: Explicitly specify native endian behaviour for syscon Mark Brown <broonie@kernel.org> - 2016-01-27 20:00 +0100
csiph-web