Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section
Date	2016-01-27 11:40 +0100
Message-ID	<qVvG2-2ab-1@gated-at.bofh.it> (permalink)
References	<qVuqB-1hZ-13@gated-at.bofh.it> <qVuAj-1nh-21@gated-at.bofh.it> <qVv3l-1Ak-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 27 January 2016 17:56:18 James Liao wrote:
> > 
> > I think you should include this change in your patch, or as a preparation.
> > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM,
> > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that
> > selects COMMON_CLK.
> 
> Oops, I didn't notice there are warnings after moving these Kconfigs
> into menu section.
> 
> The original motivation of this patch is preventing new clk drivers
> include their Kconfig in a wrong place, so it's not critical. Do you
> think we should apply this patch (with your changes below) or drop this
> patch directly?


I think your patch is good, we just need to fix S3C24xx, which is doing
things in a strange way for historic reasons.

	Arnd

Thread

[PATCH] clk: Move vendor's Kconfig into CCF menu section James Liao <jamesjj.liao@mediatek.com> - 2016-01-27 08:30 +0100
  Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section kbuild test robot <lkp@intel.com> - 2016-01-27 10:20 +0100
    Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section Arnd Bergmann <arnd@arndb.de> - 2016-01-27 10:30 +0100
      Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section James Liao <jamesjj.liao@mediatek.com> - 2016-01-27 11:00 +0100
        Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section Arnd Bergmann <arnd@arndb.de> - 2016-01-27 11:40 +0100
  Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section kbuild test robot <lkp@intel.com> - 2016-01-27 11:30 +0100

csiph-web