Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318572
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() |
| Date | 2016-01-27 03:50 +0100 |
| Message-ID | <qVolc-57c-3@gated-at.bofh.it> (permalink) |
| References | <qVhtn-gQ-7@gated-at.bofh.it> <qVhtp-gQ-57@gated-at.bofh.it> <qVn5L-4lp-5@gated-at.bofh.it> <qVnyO-4xz-13@gated-at.bofh.it> <qVnIt-4QH-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi,
On 27/01/2016 at 11:05:36 +0900, Krzysztof Kozlowski wrote :
> On 27.01.2016 10:53, Javier Martinez Canillas wrote:
> > Hello Andi,
> >
> > Thanks a lot for your feedback and review.
> >
> > On 01/26/2016 10:22 PM, Andi Shyti wrote:
> >> Hi Javier,
> >>
> >>> if (tm->tm_year < 100) {
> >>> - pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
> >>> - 1900 + tm->tm_year);
> >>> + dev_warn(info->dev,
> >>> + "RTC can't handle year %d. Assume it's 2000\n",
> >>> + 1900 + tm->tm_year);
> >>> return -EINVAL;
> >>
> >> Because we are returning an error value, why not use dev_err()?
> >>
> >
> > You are absolutely right. Since the driver was using pr_warn(), I used
> > dev_warn() but dev_err() would had been correct.
>
> Wait. The message says that "2000 will be assumed" which is not an
> error. The message indicates that driver will proceed, thus the warning.
>
> However the driver won't proceed because the max77686_rtc_set_time()
> will abort. This came from max8997 which has the same issue.
>
> This means that either message should be changed (dev_err() without the
> "assume" verb) or the function should not abort and set the year to
> 2000+something (then dev_warn()... look at rtc-ds3234.c and rtc-mcp795.c).
>
> The easiest would be to choose #1 - no changes in the logic.
>
My stance on that is to never set a date that differs from the requested
date. Else, userspace has no way of knowing whether this is an erroneous
date or the real date when reading back.
I think I had a look and the driver is already doing the right thing but
the message is wrong.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/10] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
[PATCH v3 03/10] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 03/10] rtc: max77686: Use usleep_range() instead of msleep() Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 02:30 +0100
[PATCH v3 05/10] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 05/10] rtc: max77686: Add an indirection level to access RTC registers Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-27 03:00 +0100
[PATCH v3 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 02:30 +0100
[PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 02:30 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-27 03:00 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-27 03:10 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-27 03:30 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 03:40 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-27 03:50 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-27 03:50 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-27 04:00 +0100
Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn() Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 03:20 +0100
[PATCH v3 08/10] rtc: Remove Maxim 77802 driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 08/10] rtc: Remove Maxim 77802 driver Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 02:30 +0100
Re: [PATCH v3 08/10] rtc: Remove Maxim 77802 driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-27 03:10 +0100
[PATCH v3 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 02:30 +0100
[PATCH v3 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 06/10] rtc: max77686: Add max77802 support Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-27 03:00 +0100
Re: [PATCH v3 06/10] rtc: max77686: Add max77802 support Javier Martinez Canillas <javier@dowhile0.org> - 2016-01-27 03:30 +0100
Re: [PATCH v3 06/10] rtc: max77686: Add max77802 support Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 03:30 +0100
[PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
Re: [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Andi Shyti <andi.shyti@samsung.com> - 2016-01-27 02:30 +0100
Re: [PATCH v3 04/10] rtc: max77686: Use a driver data struct instead hard-coded values Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-27 02:50 +0100
[PATCH v3 09/10] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-26 20:30 +0100
csiph-web