Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318445

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support

Show all headers | View raw

Hi,

On Thu, Jan 14, 2016 at 2:25 PM, Daniel Baluta <daniel.baluta@intel.com> wrote:
> The driver has sysfs readings with runtime PM support for power saving.
> It also offers buffer support that can be used together with IIO software
> triggers.
>
> Datasheet can be found here:
>         http://www.ti.com.cn/cn/lit/ds/symlink/ads1015.pdf
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> ---

[ ... ]

> +static const struct i2c_device_id ads1015_id[] = {
> +       {"ads1015", 0},

shouldn't this be ti-ads1015 so not to clash with the hwmon driver?

> +       {}
> +};
> +MODULE_DEVICE_TABLE(i2c, ads1015_id);
> +
> +static struct i2c_driver ads1015_driver = {
> +       .driver = {
> +               .name = ADS1015_DRV_NAME,

same here, otherwise we will have an i2c:ads1015 alias


Lucas De Marchi

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support Lucas De Marchi <lucas.de.marchi@gmail.com> - 2016-01-26 23:30 +0100
  Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-01-27 11:00 +0100

csiph-web