Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318382

Re: [PATCH 07/15] dmaengine: dw: revisit data_width property

Show all headers | View raw

On Sun, Jan 24, 2016 at 07:21:54PM +0000, Mans Rullgard wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> There are several changes are done here:
> 
>  - Convert the property to be in bytes
> 
>    Much more convenient than keeping encoded value.
> 
>  - Use one value for all AHB masters for now
> 
>    It seems in practice we have no controllers where masters have different
>    data bus width, we still might return to distinct values when there is a use
>    case.
> 
>  - Rename data_width to data-width in the device tree bindings.
> 
>  - While here, replace dwc_fast_ffs() by __ffs().
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
> This patch changes the DT binding, so it should probably be amended for
> compatibility with old device trees.  I've included it as is since I think
> the change as such is good.

Just because you update the dts files, it doesn't make the change okay. 
I'm fine with the DT change, but the driver would have to support both 
old and new property names. Doesn't really seem worth doing to me.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/15] dmaengine: dw: various fixes and cleanups Mans Rullgard <mans@mansr.com> - 2016-01-24 20:30 +0100
  [PATCH 07/15] dmaengine: dw: revisit data_width property Mans Rullgard <mans@mansr.com> - 2016-01-24 20:30 +0100
    Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2016-01-25 08:40 +0100
      Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-25 09:50 +0100
        Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Måns Rullgård <mans@mansr.com> - 2016-01-25 11:40 +0100
          Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-25 11:40 +0100
    Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-25 09:50 +0100
    Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Rob Herring <robh@kernel.org> - 2016-01-26 22:10 +0100
      Re: [PATCH 07/15] dmaengine: dw: revisit data_width property Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-27 13:30 +0100
  Re: [PATCH 00/15] dmaengine: dw: various fixes and cleanups Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-25 11:40 +0100
  Re: [PATCH 00/15] dmaengine: dw: various fixes and cleanups Vinod Koul <vinod.koul@intel.com> - 2016-01-25 13:10 +0100

csiph-web