Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1318353
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting |
| Date | 2016-01-26 21:50 +0100 |
| Message-ID | <qViIO-1ad-17@gated-at.bofh.it> (permalink) |
| References | <qV7X4-1ZG-13@gated-at.bofh.it> <qV7X5-1ZG-33@gated-at.bofh.it> <qVgnE-7Zo-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 26 Jan 2016, Heiko Carstens wrote:
> On Tue, Jan 26, 2016 at 10:18:25AM +0100, Christian Borntraeger wrote:
> > We can use debug_pagealloc_enabled() to check if we can map
> > the identity mapping with 1MB/2GB pages as well as to print
> > the current setting in dump_stack.
> >
> > Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> > ---
> > arch/s390/kernel/dumpstack.c | 4 +++-
> > arch/s390/mm/vmem.c | 10 ++++------
> > 2 files changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/s390/kernel/dumpstack.c b/arch/s390/kernel/dumpstack.c
> > index dc8e204..a1c0530 100644
> > --- a/arch/s390/kernel/dumpstack.c
> > +++ b/arch/s390/kernel/dumpstack.c
> > @@ -11,6 +11,7 @@
> > #include <linux/export.h>
> > #include <linux/kdebug.h>
> > #include <linux/ptrace.h>
> > +#include <linux/mm.h>
> > #include <linux/module.h>
> > #include <linux/sched.h>
> > #include <asm/processor.h>
> > @@ -186,7 +187,8 @@ void die(struct pt_regs *regs, const char *str)
> > printk("SMP ");
> > #endif
> > #ifdef CONFIG_DEBUG_PAGEALLOC
> > - printk("DEBUG_PAGEALLOC");
> > + printk("DEBUG_PAGEALLOC(%s)",
> > + debug_pagealloc_enabled() ? "enabled" : "disabled");
> > #endif
>
> I'd prefer if you change this to
>
> if (debug_pagealloc_enabled())
> printk("DEBUG_PAGEALLOC");
>
> That way we can get rid of yet another ifdef. Having
> "DEBUG_PAGEALLOC(disabled)" doesn't seem to be very helpful.
Yes, same for x86 please.
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH/RFC 0/3] Optimize CONFIG_DEBUG_PAGEALLOC Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-26 10:20 +0100
[PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-26 10:20 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-01-26 19:20 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Thomas Gleixner <tglx@linutronix.de> - 2016-01-26 21:50 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting David Rientjes <rientjes@google.com> - 2016-01-27 00:30 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-27 01:20 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting David Rientjes <rientjes@google.com> - 2016-01-27 01:40 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-27 02:00 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-27 09:00 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Vlastimil Babka <vbabka@suse.cz> - 2016-01-27 13:50 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-27 13:50 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-27 14:10 +0100
Re: [PATCH/RFC 3/3] s390: query dynamic DEBUG_PAGEALLOC setting Vlastimil Babka <vbabka@suse.cz> - 2016-01-27 14:10 +0100
csiph-web