Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1318200

Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

Show all headers | View raw

On Thu, 21 Jan 2016, Zhao Qiang wrote:

> 127 is the theoretical up boundary of QEIC number,
> in fact there only be 44 qe_ic_info now.
> add check to overflow for qe_ic_info

How do you trigger that overflow? The above does not explain WHY we need these
checks.

> diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
> index 5419527..90c00b7 100644
> --- a/drivers/soc/fsl/qe/qe_ic.c
> +++ b/drivers/soc/fsl/qe/qe_ic.c

Sigh. Another dump ground for SOC stuff? irq chip drivers belong into
drivers/irqchip.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] qe_ic: fix a buffer overflow error and add check  elsewhere Thomas Gleixner <tglx@linutronix.de> - 2016-01-26 18:40 +0100
  Re: [PATCH] qe_ic: fix a buffer overflow error and add check  elsewhere Scott Wood <oss@buserror.net> - 2016-01-26 19:10 +0100

csiph-web