Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments

From	Johannes Weiner <hannes@cmpxchg.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments
Date	2016-01-26 16:40 +0100
Message-ID	<qVdSP-644-29@gated-at.bofh.it> (permalink)
References	<qVcWK-5sj-21@gated-at.bofh.it> <qVdpM-5RZ-31@gated-at.bofh.it> <qVdzs-5Vw-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 26, 2016 at 04:14:30PM +0100, Andreas Ziegler wrote:
> On 01/26/2016 16:08, Rosen, Rami wrote:
> > Hi, 
> > 
> > --- a/include/linux/cgroup.h
> > +++ b/include/linux/cgroup.h
> > @@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd)
> >  #endif
> >  }
> > 
> > In this occasion, seems that maybe something else is also missing:
> > Shouldn't it be hereafter : +#else /* !CONFIG_SOCK_CGROUP_DATA */ 
> > instead ? 
> >    
> > -#else	/* CONFIG_CGROUP_DATA */
> > +#else	/* CONFIG_SOCK_CGROUP_DATA */
> 
> It seems that there is no real consensus among the developers for that
> particular case:
> 
> ziegler@box:~/linux$ git grep "#else \/\* \!CONFIG_" | wc -l
> 327
> ziegler@box:~/linux$ git grep "#else \/\* CONFIG_" | wc -l
> 564

The comments after #ifdef, #ifndef, #else, #endif name the condition
that is being branched on, not the condition that is in effect after
a specific line. Case in point: #endif /* CONFIG_SOCK_CGROUP_DATA */

Stick with the majority, and save a byte!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments Andreas Ziegler <andreas.ziegler@fau.de> - 2016-01-26 15:40 +0100
  RE: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in  comments "Rosen, Rami" <rami.rosen@intel.com> - 2016-01-26 16:10 +0100
    Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in  comments Andreas Ziegler <andreas.ziegler@fau.de> - 2016-01-26 16:20 +0100
      Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in  comments Johannes Weiner <hannes@cmpxchg.org> - 2016-01-26 16:40 +0100

csiph-web