Re: [PATCH v7 0/9] watchdog: Add support for keepalives triggered by infrastructure

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 0/9] watchdog: Add support for keepalives triggered by infrastructure
Date	2016-01-26 15:50 +0100
Message-ID	<qVd6q-5vL-7@gated-at.bofh.it> (permalink)
References	<qV21j-4Zc-3@gated-at.bofh.it> <qV6Rj-1gU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Uwe,

On 01/26/2016 12:09 AM, Uwe Kleine-König wrote:
> Hello Guenter,
>
> On Mon, Jan 25, 2016 at 06:53:07PM -0800, Guenter Roeck wrote:
>> Patch #1 adds timer functionality to the watchdog core. It solves the problem
>> of short maximum hardware timeouts by augmenting heartbeats triggered from
>> user space with internally triggered heartbeats.
>>
>> Patch #2 adds functionality to generate heartbeats while the watchdog device
>> is closed. It handles situation where where the watchdog is running after
>> the driver has been instantiated, but the device is not yet opened,
>> and post-close situations necessary if a watchdog can not be stopped.
>>
>> Patch #3 makes the set_timeout function optional. This is now possible since
>> timeout changes can now be completely handled in the watchdog core, for
>> example if the hardware watchdog timeout is fixed.
>>
>> Patch #4 adds code to ensure that the minimum time between heartbeats meets
>> constraints provided by the watchdog driver.
>>
>> Patch #5 simplifies the watchdog_update_worker() function introduced with
>> patch #1 to only take a single argument, and to always cancel any pending
>> work if a worker is not or no longer needed. This patch is kept as separate
>> patch on purpose, to enable dropping or reverting it easily if it causes
>> any problems. It should not cause any problems; this is just out of an
>> abundance of caution.
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> for patches
> 1-5.
>

Thanks a lot for your time!

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/9] watchdog: Add support for keepalives triggered by infrastructure Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [RFT PATCH v7 7/9] watchdog: retu: Convert to use infrastructure triggered keepalives Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [RFT PATCH v7 8/9] watchdog: at91sam9: Convert to use infrastructure triggered keepalives Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [PATCH v7 1/9] watchdog: Introduce hardware maximum timeout in watchdog core Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [RFT PATCH v7 9/9] watchdog: dw_wdt: Convert to use watchdog infrastructure Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [PATCH v7 3/9] watchdog: Make set_timeout function optional Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [PATCH v7 5/9] watchdog: Simplify update_worker Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [PATCH v7 2/9] watchdog: Introduce WDOG_HW_RUNNING flag Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
  [PATCH v7 4/9] watchdog: Add support for minimum time between heartbeats Guenter Roeck <patchwork@patchwork.roeck-us.net> - 2016-01-26 04:00 +0100
    Re: [PATCH v7 4/9] watchdog: Add support for minimum time between  heartbeats Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-01-26 09:10 +0100
      Re: [PATCH v7 4/9] watchdog: Add support for minimum time between  heartbeats Guenter Roeck <linux@roeck-us.net> - 2016-01-26 15:50 +0100
  Re: [PATCH v7 0/9] watchdog: Add support for keepalives triggered by  infrastructure Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-01-26 09:10 +0100
    Re: [PATCH v7 0/9] watchdog: Add support for keepalives triggered by  infrastructure Guenter Roeck <linux@roeck-us.net> - 2016-01-26 15:50 +0100

csiph-web