[PATCH v2 1/2] crypto: sunxi - don't print confusing data

Path	csiph.com!news.freedyn.net!newsfeed.datemas.de!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/2] crypto: sunxi - don't print confusing data
Date	Tue, 26 Jan 2016 14:50:02 +0100
Message-ID	<qVcal-4P7-5@gated-at.bofh.it> (permalink)
X-Original-To	Herbert Xu <herbert@gondor.apana.org.au>
X-Mailer	git-send-email 2.7.0
X-Provags-ID	V03:K0:l+xcr5w1lDWsIcKTLUFGrgEhxwth2zmIRRf6kE9FNI0JfcLe1B8 yFDc9+lOTdA53yvbBNTrSBCP4b+Nqom3KjX3c5w6pWYbUsfjTCBX7j4cmvMOmthZg9eua7N uX+ptJFvz9tPXd5z2lvNb5orfV8uf9znwx+yFlMqaKJogA498GvBEhcfDaeY24n9lRkvMfC x9d4CpjCIGiagB4QXP56Q==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:rGaxsTCM4cI=:rZEYZiCx8ka8GeiV1qxzZG VSFkG7dUnn04VNZ1kyQBDza0qESQzQ0NTGgdlooYiSDxk383pKmMQglz2cf8+cM5fFWSfTIiJ 2zYhKGd5z3CbHxCEcDruEzjgr81k3SEe1NN+WtuIWtu2re2qID3GJmHM505TTh9u58cp0j8kF ApT7DKpOt9taI9TDiIMw1G0OgTOKf1Sslf+Sy5IhMMMI0zya3NnbXO96tqct/9buCUoKJX1wG zgXqbvV9zfbPViRLmZsc5kZ/ABKpSw5t+BkTflilrSGhnVzJOsgeZiu36Lr3YjQyT+rlAG5x7 wDfJdCuAAKACEx6p1959OzAk/Z9WZ0tw3Zw5EJagqdOlnotqBjwsUDj3DeaNPVgcfc5tN6avI WVnHOViH3Lwlh/REc2LRwJY+TsYQ55TzGAwzIFYki/hcXMSIDH7XMd+jSOtWXVyYpNDcJEzSl 1RoRHtYmYTrHjg637O34Uy38J7Y+YTEzAbxizz26M9YC/d+EpUsZh8Tn7Jlx+SwDMsUCxj3Kz 8mfVE7vNfQs6HspjuBg60of67H8j7Kwx0vydcO0Srawawudw9eCPAI9T2L984+SYEZlJc0AWx wK3vZu0icQKMTzVdjNRvnlg7iOmsCA8Om2rxySS6MkUwPQ7UWGdGQ8UbXlMIJ0MQDsUWXBB24 qV9bM4YnJUnOwxk206wixdBGKKA8KtxMr2+kN75tbqed24NIXIysNyS0qEvhKX/iSh3g=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, Corentin Labbe <clabbe.montjoie@gmail.com>, "David S. Miller" <davem@davemloft.net>, Maxime Ripard <maxime.ripard@free-electrons.com>, Chen-Yu Tsai <wens@csie.org>, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 26 Jan 2016 14:44:50 +0100
X-Original-Message-ID	<1453815902-3070323-1-git-send-email-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1317923

Show key headers only | View raw

gcc correctly warns that the printk output contains a variable that
it thinks is not initialized in some cases:

drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll':
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:254:76: warning: 'todo' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:144:15: note: 'todo' was declared here

A closer look at the function reveals that the variable is always
initialized at this point (ileft is guaranteed to be positive at the
start), but its contents are not well-defined:
Depending on some other variables, it might be either a count in
words or bytes, and it could refer to either input or output.

The easiest solution apparently is to remove the confusing output
and let the reader figure out the state from the other variables.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/crypto/sunxi-ss/sun4i-ss-cipher.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c
index a19ee127edca..7be3fbcd8d78 100644
--- a/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c
+++ b/drivers/crypto/sunxi-ss/sun4i-ss-cipher.c
@@ -251,11 +251,10 @@ static int sun4i_ss_cipher_poll(struct ablkcipher_request *areq)
 		spaces = readl(ss->base + SS_FCSR);
 		rx_cnt = SS_RXFIFO_SPACES(spaces);
 		tx_cnt = SS_TXFIFO_SPACES(spaces);
-		dev_dbg(ss->dev, "%x %u/%u %u/%u cnt=%u %u/%u %u/%u cnt=%u %u %u\n",
+		dev_dbg(ss->dev, "%x %u/%u %u/%u cnt=%u %u/%u %u/%u cnt=%u %u\n",
 			mode,
 			oi, mi.length, ileft, areq->nbytes, rx_cnt,
-			oo, mo.length, oleft, areq->nbytes, tx_cnt,
-			todo, ob);
+			oo, mo.length, oleft, areq->nbytes, tx_cnt, ob);
 
 		if (tx_cnt == 0)
 			continue;
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/2] crypto: sunxi - don't print confusing data Arnd Bergmann <arnd@arndb.de> - 2016-01-26 14:50 +0100
  Re: [PATCH v2 1/2] crypto: sunxi - don't print confusing data Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 15:20 +0100
  Re: [PATCH v2 1/2] crypto: sunxi - don't print confusing data Corentin LABBE <clabbe.montjoie@gmail.com> - 2016-01-27 20:50 +0100

csiph-web