Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1317922

[PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Arnd Bergmann <arnd@arndb.de>
Newsgroups linux.kernel
Subject [PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG
Date Tue, 26 Jan 2016 14:50:01 +0100
Message-ID <qVcal-4P7-3@gated-at.bofh.it> (permalink)
References <qVcal-4P7-5@gated-at.bofh.it>
X-Mailer git-send-email 2.7.0
X-Provags-ID V03:K0:6WgmVxTbuxCFpWTkEs+8tadA2JPwL5DEus5NNEQkCjIMEWoaWWZ Stfl8jjO0FLbR9B9WWNCY0EwnMjDb92YE2m6XYF90S0sJqs5v7pF6Q0BA6B1CJLVa4KHo18 WdmyPOHdmB96OaQqSWS+tgr42DQ2Mciv7aTditkavHgS7uQ0toIysiczPSVunQRRLIwrHEN SfDecDq1Y9y1l7QiXYfsA==
X-Ui-Out-Filterresults notjunk:1;V01:K0:ZekAv7P/Aic=:6v3FkqZG9oHIQagsVH70YT vUC7M/Vf8Djd2D5Utow0MnVWkRVkyhxiULqmDjk6NQsGIaJfHDc8EvBbqc7JMXuJOJkrF6IrB ruzDGy7TEdmTCnWwZARi/kiZ4D8i6IMqyIEjlgL0u8m2bAEs21cxMdavKYvZizfGwywG4iqcd TsHbWjpE2k877VfJp3RXmHGuvmDqVOotbD+oJwa+Iqfa+S0pw6KhVAlAlRbA576E6sw4ohjOT D63ZmKLOTKVZR8y1YlHD15W45G3WJp3sJEJn08dM8a0iEpLpCr7SEg6Z0+6ScO70dGcl/gFVN 9/RWZY2MJFCBxAVRls7oPBTsTa/m9zmrIaoWx/yrfh9VuD3ACmRTaU5uHhagj8ocdJwkKQHQX P9SjD3koEwW2b4SmV88fy6pJIQxMsTA4GPKw3QSYQVnTqHFaQqCi0n6OI9q0uCS1wPumH/hv5 9buMIBZL7kSV3ouEAwgac2gyqqR1h8J0EzstuI0hxVEeOjNkrlSHTZF/cULWTW8wNAUOBC7SY QbNS/+4trODE+SS8Fvzx69VbZOaa5+iYGa8WoDcTD91HZvowWahCUgD+GFtXR0VP8fi+wmNzD VPqEBBSpheInhVKxjC567OFYmEPU1MJzdOgJVfU0NpWBDNLu4Ddbb1gg9SIGpLiGh9LyZuUFl YwbrxuxksGDz5lwtDp4cdVYG2QHxSG+NynAz6tVbkOASu6vBA8AS/jOvH45D5oZdUkMw=
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 32
Organization linux.* mail to news gateway
X-Original-Cc linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Tue, 26 Jan 2016 14:47:10 +0100
X-Original-Message-ID <1453816035-3070440-1-git-send-email-arnd@arndb.de>
X-Original-References <1453815902-3070323-1-git-send-email-arnd@arndb.de>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1317922

Show key headers only | View raw


When building the jitterentropy driver by itself, we get a link error
when CRYPTO_RNG is not enabled as well:

crypto/built-in.o: In function `jent_mod_init':
jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to `crypto_register_rng'
crypto/built-in.o: In function `jent_mod_exit':
jitterentropy-kcapi.c:(.exit.text+0x60): undefined reference to `crypto_unregister_rng'

This adds a 'select CRYPTO_RNG' to CRYPTO_JITTERENTROPY to ensure the API
is always there when it's used, not just when DRBG is also enabled.
CRYPTO_DRBG would set it implicitly through CRYPTO_JITTERENTROPY now,
but this leaves it in place to make it explicit what the driver does.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 3be07ad1d80d..88248821af82 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1595,6 +1595,7 @@ endif	# if CRYPTO_DRBG_MENU
 
 config CRYPTO_JITTERENTROPY
 	tristate "Jitterentropy Non-Deterministic Random Number Generator"
+	select CRYPTO_RNG
 	help
 	  The Jitterentropy RNG is a noise that is intended
 	  to provide seed to another RNG. The RNG does not
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG Arnd Bergmann <arnd@arndb.de> - 2016-01-26 14:50 +0100
  Re: [PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-27 15:20 +0100

csiph-web