Re: [PATCH] i2c: imx: add slave support

From	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] i2c: imx: add slave support
Date	2016-01-26 14:40 +0100
Message-ID	<qVc0F-4LK-3@gated-at.bofh.it> (permalink)
References	<qUTKq-7UQ-11@gated-at.bofh.it> <qV7aG-1qe-17@gated-at.bofh.it> <qV7km-1uA-27@gated-at.bofh.it> <qV8zN-2fZ-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 26.01.2016 11:54, Dmitriy Baranov wrote:
> Sorry, we should have added selecting this in our patch.
> The following fixes it:
> 
> Subject: [PATCH] Select I2C_SLAVE for i2c-imx driver because it uses the 
> generic slave interface.
> 
> Signed-off-by: Dmitriy Baranov <dbaranov@dev.rtsoft.ru>
> Signed-off-by: Maxim Syrchin <syrchin@dev.rtsoft.ru>
> ---
>   drivers/i2c/busses/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 0299dfa..bc7cbfd 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -587,6 +587,7 @@ config I2C_IMG
>   config I2C_IMX
>       tristate "IMX I2C interface"
>       depends on ARCH_MXC || ARCH_LAYERSCAPE
> +    select I2C_SLAVE
>       help
>         Say Y here if you want to use the IIC bus controller on
>         the Freescale i.MX/MXC or Layerscape processors.
> 

Could you please squash the changes (care about indentation in Kconfig also)
and resend it as v2 (probably you may want to wait for review comments some
more time)?

Two more formal questions, why patch submitter's Signed-off-by: is not the
last in the list and why Maxim has Signed-off-by tag here? Who is the author
of the change?

See Documentation/SubmittingPatches "Sign your work" for details.

Best wishes,
Vladimir

Thread

Re: [PATCH] i2c: imx: add slave support Dmitriy Baranov <dbaranov@dev.rtsoft.ru> - 2016-01-26 09:30 +0100
  Re: [PATCH] i2c: imx: add slave support Wolfram Sang <wsa@the-dreams.de> - 2016-01-26 09:40 +0100
    Re: [PATCH] i2c: imx: add slave support Dmitriy Baranov <dbaranov@dev.rtsoft.ru> - 2016-01-26 11:00 +0100
      Re: [PATCH] i2c: imx: add slave support Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-01-26 14:40 +0100
        Re: [PATCH] i2c: imx: add slave support Dmitriy Baranov <dbaranov@dev.rtsoft.ru> - 2016-01-26 15:20 +0100
          Re: [PATCH] i2c: imx: add slave support Wolfram Sang <wsa@the-dreams.de> - 2016-01-26 16:20 +0100

csiph-web