Groups > linux.kernel > #1320862

Re: [PATCH] mm, vmstat: make quiet_vmstat lighter (was: Re: fast path cycle muncher (vmstat: make vmstat_updater deferrable) again and shut down on idle)

From	Christoph Lameter <cl@linux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm, vmstat: make quiet_vmstat lighter (was: Re: fast path cycle muncher (vmstat: make vmstat_updater deferrable) again and shut down on idle)
Date	2016-01-28 17:50 +0100
Message-ID	<qVXVE-69J-29@gated-at.bofh.it> (permalink)
References	(6 earlier) <qTN4n-6Dx-31@gated-at.bofh.it> <qU9ey-5ik-15@gated-at.bofh.it> <qVBs7-6oZ-53@gated-at.bofh.it> <qVD0S-7IE-25@gated-at.bofh.it> <qVWPU-5sX-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 28 Jan 2016, Michal Hocko wrote:

> Thinking about it some more, making vmstat_update deferrable should help
> to not interrupt idle no?

It will align with the tick then. Yes indeed this should be done.
> ---
> diff --git a/mm/vmstat.c b/mm/vmstat.c
> index eb30bf45bd55..69537d2be6f6 100644
> --- a/mm/vmstat.c
> +++ b/mm/vmstat.c
> @@ -1512,7 +1512,7 @@ static void __init start_shepherd_timer(void)
>  	int cpu;
>
>  	for_each_possible_cpu(cpu)
> -		INIT_DELAYED_WORK(per_cpu_ptr(&vmstat_work, cpu),
> +		INIT_DEFERRABLE_WORK(per_cpu_ptr(&vmstat_work, cpu),
>  			vmstat_update);
>
>  	if (!alloc_cpumask_var(&cpu_stat_off, GFP_KERNEL))
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm, vmstat: make quiet_vmstat lighter (was: Re: fast  path cycle muncher (vmstat: make vmstat_updater deferrable) again and shut  down on idle) Michal Hocko <mhocko@kernel.org> - 2016-01-28 16:40 +0100
  Re: [PATCH] mm, vmstat: make quiet_vmstat lighter (was: Re: fast  path cycle muncher (vmstat: make vmstat_updater deferrable) again and shut  down on idle) Christoph Lameter <cl@linux.com> - 2016-01-28 17:50 +0100

csiph-web