Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320749
| Path | csiph.com!weretis.net!feeder6.news.weretis.net!news.glorb.com!bofh.it!news.nic.it!robomod |
|---|---|
| From | Mark Rutland <mark.rutland@arm.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional |
| Date | Thu, 28 Jan 2016 16:00:02 +0100 |
| Message-ID | <qVWdc-4Sp-3@gated-at.bofh.it> (permalink) |
| References | <qSIT8-33H-5@gated-at.bofh.it> <qSIT8-33H-11@gated-at.bofh.it> <qVFFn-1hk-9@gated-at.bofh.it> <qVFFn-1hk-7@gated-at.bofh.it> <qVIjU-3hE-7@gated-at.bofh.it> <qVSCC-2xh-1@gated-at.bofh.it> <qVVqN-4wq-1@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=us-ascii |
| Content-Disposition | inline |
| User-Agent | Mutt/1.5.21 (2010-09-15) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 38 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | David Brown <david.brown@linaro.org>, "kernel-hardening@lists.openwall.com" <kernel-hardening@lists.openwall.com>, Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@amacapital.net>, "H. Peter Anvin" <hpa@zytor.com>, Michael Ellerman <mpe@ellerman.id.au>, Mathias Krause <minipli@googlemail.com>, Thomas Gleixner <tglx@linutronix.de>, "x86@kernel.org" <x86@kernel.org>, Arnd Bergmann <arnd@arndb.de>, PaX Team <pageexec@freemail.hu>, Emese Revfy <re.emese@gmail.com>, LKML <linux-kernel@vger.kernel.org>, linux-arch <linux-arch@vger.kernel.org>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Marc Zyngier <marc.zyngier@arm.com>, yalin wang <yalin.wang2010@gmail.com>, Zi Shen Lim <zlim.lnx@gmail.com>, Yang Shi <yang.shi@linaro.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, Laura Abbott <lauraa@codeaurora.org>, "Suzuki K. Poulose" <suzuki.poulose@arm.com>, Steve Capper <steve.capper@linaro.org>, Jeremy Linton <jeremy.linton@arm.com>, Mark Salter <msalter@redhat.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> |
| X-Original-Date | Thu, 28 Jan 2016 14:59:01 +0000 |
| X-Original-Message-ID | <20160128145900.GN17123@leverpostej> |
| X-Original-References | <1453226922-16831-1-git-send-email-keescook@chromium.org> <1453226922-16831-4-git-send-email-keescook@chromium.org> <20160127211105.GA41450@davidb.org> <CAGXu5j+DLRoVE88a9++jVfEkN90HDiAaDAMnT2TrKqtMZ_yOww@mail.gmail.com> <20160128000906.GA42530@davidb.org> <20160128110622.GF17123@leverpostej> <CAGXu5jLy3cpLzU1MSQhS6q=5rMu2Mdp9pXncoFapPqUyQ1fO0A@mail.gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1320749 |
Show key headers only | View raw
On Thu, Jan 28, 2016 at 06:06:53AM -0800, Kees Cook wrote:
> On Thu, Jan 28, 2016 at 3:06 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> > One thing I would like to do is to avoid the need for fixup_executable
> > entirely, by mapping the kernel text RO from the outset. However, that
> > requires rework of the alternatives patching (to use a temporary RW
> > alias), and I haven't had the time to look into that yet.
>
> This makes perfect sense for the rodata section, but the (future)
> postinit_rodata section we'll still want to mark RO after init
> finishes. x86 and ARM cheat by marking both RO after init, and they
> don't have to pad sections. parisc will need to solve this too.
Depending on how many postinit_rodata variables there are, we might be
able to drop those in .rodata, have them RO always, and initialise them
via a temporary RW alias (e.g. something in the vmalloc area).
The only requirement for that is that we use a helper to initialise any
__postinit_ro variables via a temporary RW alias, e.g.
#define SET_POST_INIT_RO(ptr, v) ({ \\
typeof(ptr) __ptr_rw = (ptr) \\
BUG_ON(initcalls_done); \\
__ptr_rw = create_rw_alias(__ptr); \\
__ptr_rw = v; \\
destroy_rw_alias(__ptr_rw); \\
})
...
__postinit_ro void *thing;
void __init some_init_func(void) {
void *__thing = some_ranodomized_allocator();
SET_POSTINIT_RO(thing, thing);
}
Mark.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional David Brown <david.brown@linaro.org> - 2016-01-28 01:10 +0100
Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional Kees Cook <keescook@chromium.org> - 2016-01-28 01:20 +0100
Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-01-28 09:30 +0100
Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional Mark Rutland <mark.rutland@arm.com> - 2016-01-28 12:10 +0100
Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional Kees Cook <keescook@chromium.org> - 2016-01-28 15:10 +0100
Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional Mark Rutland <mark.rutland@arm.com> - 2016-01-28 16:00 +0100
Re: [PATCH] arm64: make CONFIG_DEBUG_RODATA non-optional Kees Cook <keescook@chromium.org> - 2016-01-28 16:20 +0100
csiph-web