Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320754
| From | Daniel Wagner <daniel.wagner@bmw-carit.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error |
| Date | 2016-01-28 16:00 +0100 |
| Message-ID | <qVWdc-4Sp-17@gated-at.bofh.it> (permalink) |
| References | <qVWdc-4Sp-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
With the introduction of the simple wait API we have two very similar APIs in the kernel. For example wake_up() and swake_up() is only one character away. Although the compiler will warn happily the wrong usage it keeps on going an even links the kernel. Thomas and Peter would rather like to see early missuses reported as error early on. In a first attempt we tried to wrap all swait and wait calls into a macro which has an compile time type assertion. The result was pretty ugly and wasn't able to catch all wrong usages. woken_wake_function(), autoremove_wake_function() and wake_bit_function() are assigned as function pointers. Wrapping them with a macro around is not possible. Prefixing them with '_' was also not a real option because there some users in the kernel which do use them as well. All in all this attempt looked to intrusive and too ugly. An alternative is to turn the pointer type check into an error which catches wrong type uses. Obviously not only the swait/wait ones. That isn't a bad thing either. Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 9d94ade..653fd08 100644 --- a/Makefile +++ b/Makefile @@ -767,6 +767,9 @@ KBUILD_CFLAGS += $(call cc-option,-Werror=strict-prototypes) # Prohibit date/time macros, which would make the build non-deterministic KBUILD_CFLAGS += $(call cc-option,-Werror=date-time) +# enforce correct pointer usage +KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types) + # use the deterministic mode of AR if available KBUILD_ARFLAGS := $(call ar-option,D) -- 2.5.0
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-28 16:00 +0100
Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-29 13:30 +0100
Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-29 20:00 +0100
Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-02-01 07:50 +0100
Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-02-05 09:20 +0100
Re: [PATCH tip v6 2/5] kbuild: Add option to turn incompatible pointer check into error Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-07 05:50 +0100
csiph-web