Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320631

Re: [PATCH] gpu: drm: amd: amdkfd: Remove unnecessary cast in kfree

Show all headers | View raw

On Mon, Jan 25, 2016 at 7:33 PM, Amitoj Kaur Chawla
<amitoj1606@gmail.com> wrote:
> Remove an unnecassary cast in the argument to kfree.
>
> Found using Coccinelle. The semantic patch used to find this is as follows:
>
> //<smpl>
> @@
> type T;
> expression *f;
> @@
>
> - kfree((T *)(f));
> + kfree(f);
> //</smpl>
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 9be0070..a902ae0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -194,7 +194,7 @@ static void kfd_process_wq_release(struct work_struct *work)
>
>         kfree(p);
>
> -       kfree((void *)work);
> +       kfree(work);
>  }
>
>  static void kfd_process_destroy_delayed(struct rcu_head *rcu)
> --
> 1.9.1
>

Thanks!
Applied to my -fixes tree.
For future reference, use "drm/amdkfd: ..." as the prefix of the
subject line. I fixed it for this patch.

       Oded

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] gpu: drm: amd: amdkfd: Remove unnecessary cast in kfree Oded Gabbay <oded.gabbay@gmail.com> - 2016-01-28 13:50 +0100
  Re: [PATCH] gpu: drm: amd: amdkfd: Remove unnecessary cast in kfree Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-01-28 14:00 +0100

csiph-web