Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320653

Re: [PATCH] printk, allow different timestamps for printk.time [v2]

Show all headers | View raw

On 01/28/2016 07:52 AM, Vasily Averin wrote:
> Dear Prarit,
> 

Hi Vasily,  Thanks for your suggestions.

> I have no objections about your patch,
> bit in fact I doubt we really need to convert each timestamp in kernel logs.
> How do you think is it probably better to convert only one timestamp per screen ?

How do you measure a screen? :)

> I.e. convert it in each 25th string only?

While your suggestion does work for a flood of messages this will miss
situations where an event occurred hours/minutes/seconds earlier leading to a
panic.

> Or just do it once per N seconds?

I've tried several other versions of the patch and other userspace options (such
as "date +%N > /tmp/kmsg" every second, setting up a timer to dump the real
time,  etc.).  Assuming that the disks didn't die (which was also part of the
problem I have seen) the printk buffer is finite in size and it is easy to fill
the buffer if you're not careful.

> And do not replace original timestamp but add converted one?

I'm not sure I see the benefit of having two timestamps but if someone really
wanted that I could add an additional patch to do it.

At the end of the day I need to be able to determine in real time what happened
on a system and to make that as easy as possible for a human to read.

P.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] printk, allow different timestamps for printk.time [v2] Prarit Bhargava <prarit@redhat.com> - 2016-01-28 13:50 +0100
  Re: [PATCH] printk, allow different timestamps for printk.time [v2] Vasily Averin <vvs@virtuozzo.com> - 2016-01-28 14:00 +0100
    Re: [PATCH] printk, allow different timestamps for printk.time [v2] Prarit Bhargava <prarit@redhat.com> - 2016-01-28 14:20 +0100
      Re: [PATCH] printk, allow different timestamps for printk.time [v2] Vasily Averin <vvs@virtuozzo.com> - 2016-01-28 15:00 +0100
  Re: [PATCH] printk, allow different timestamps for printk.time [v2] Petr Mladek <pmladek@suse.com> - 2016-02-04 17:50 +0100
    Re: [PATCH] printk, allow different timestamps for printk.time [v2] Prarit Bhargava <prarit@redhat.com> - 2016-02-04 18:10 +0100
      Re: [PATCH] printk, allow different timestamps for printk.time [v2] Petr Mladek <pmladek@suse.com> - 2016-02-08 17:00 +0100
        Re: [PATCH] printk, allow different timestamps for printk.time [v2] Prarit Bhargava <prarit@redhat.com> - 2016-02-08 17:10 +0100
    Re: [PATCH] printk, allow different timestamps for printk.time  [v2] Thomas Gleixner <tglx@linutronix.de> - 2016-02-04 18:30 +0100

csiph-web