Groups > linux.kernel > #1320597

Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section
Date	Thu, 28 Jan 2016 12:40:03 +0100
Message-ID	<qVT5F-2Js-31@gated-at.bofh.it> (permalink)
References	<qVuqB-1hZ-13@gated-at.bofh.it> <qVvG2-2ab-1@gated-at.bofh.it> <qVQhs-Jf-13@gated-at.bofh.it>
User-Agent	KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
X-Provags-ID	V03:K0:7/HO6xhB5Bune6MWGKwLaMTQwSb7gDpY68lsPwIPotlSY/QzOjk OrOLOL/puT9/XlSRlf67k5adhsErMM6hDVyekJIaYSjcdLVxEE7QQHVbDw0dGWWNNLfgH5a ZRFz6y+06J7iDTfrZNnHY9ohn8OJBtRAO7ruZGksa8ghFX9GHh7v/msTx0PD82OPsX0QqBc sYwWwP07VazGvdjEQ26VA==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:MdTXGW2Nxno=:zCbHEetgRMSzMXa6WvSdmR 6nUxlYvHm/4sAK94pdjYS7J1vREj8IIfO7klwDxcqz9ikhrJJFPVWMvbKAwiJPSWiitI4AU+Y UFZ6ggIeQDtS7c2Ri0WFLW+Hmc4wM4a1a58x+tLZIdKImfWCyFTaHku60HYg4HN/CGeG491+x FBS/b62+3J0awkX0ldtQQQ4iBnNsFGg2kGGNNBd7HueQPuoa9XcSJTFWWyvaGebM/ZHZfwdpt STIxvVYUKu2V+Cp67VN1uMIm6NDoX9Ef/JXBX0JHrGRE5mMhzPpt4IMFzfRYuD4krmfb3t2+d YFcd1C/OfiUR0cYU38/Wy4KtYO1j0vD33HLttKzOo5lu1gWow9dVmdmP74DGyOAN7wVfEMyhE qqR6LZx287GuPW7gkUdHmEeM9bSZh7JgsBl1kAyIXFfJAjboUw2Xi3UohthxDZP7vkryqrDDO EewiSSw7YUw9JYfsFb6++dnpSj7qgepDGxNiUuNYPN9YyLILmO05GDo+VByE1ZvbaHimXLWWK DPLwz/Bq5eriHFlxROcYJP5dogVfROrTp+7LGyBKtTUxbdbN7itLCWSXb57DohuyZ2pvxX9UF aoDSedorkGCNRLISFh82otnQcRmF75zUgsJmD+Gu/x1gB79KPZeqPh1yhuC3uhvgl2wVeqlFc eprd/0G6BpC5j5UUaBRsIe7rlwVCH2s95SKFNR8R90+LtcE4lyk47WniLsihE3cu8ZPk24a7O IEWhPT4DRutJbBbz
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	James Liao <jamesjj.liao@mediatek.com>, linux-arm-kernel@lists.infradead.org, kbuild test robot <lkp@intel.com>, srv_heupstream@mediatek.com, devicetree@vger.kernel.org, Mike Turquette <mturquette@baylibre.com>, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, kbuild-all@01.org, Sascha Hauer <kernel@pengutronix.de>, Matthias Brugger <matthias.bgg@gmail.com>, linux-clk@vger.kernel.org
X-Original-Date	Thu, 28 Jan 2016 12:31:59 +0100
X-Original-Message-ID	<1505403.Puq3Qui8Zr@wuerfel>
X-Original-References	<201601271708.gQUxXACW%fengguang.wu@intel.com> <6167008.u8jfFpmfhy@wuerfel> <20160128083656.GM12841@codeaurora.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1320597

Show key headers only | View raw

On Thursday 28 January 2016 00:36:56 Stephen Boyd wrote:
> On 01/27, Arnd Bergmann wrote:
> > On Wednesday 27 January 2016 17:56:18 James Liao wrote:
> > > > 
> > > > I think you should include this change in your patch, or as a preparation.
> > > > All other samsung platforms already select COMMON_CLK through ARCH_MULTIPLATFORM,
> > > > and all SoCs that are part of ARCH_S3C24XX individually select a symbol that
> > > > selects COMMON_CLK.
> > > 
> > > Oops, I didn't notice there are warnings after moving these Kconfigs
> > > into menu section.
> > > 
> > > The original motivation of this patch is preventing new clk drivers
> > > include their Kconfig in a wrong place, so it's not critical. Do you
> > > think we should apply this patch (with your changes below) or drop this
> > > patch directly?
> > 
> > 
> > I think your patch is good, we just need to fix S3C24xx, which is doing
> > things in a strange way for historic reasons.
> 
> So far we've taken the approach of not caring if they include
> their Kconfig outside the common clk menu when all the configs
> inside the Kconfig file are hidden. Of course, when they aren't
> hidden this becomes a problem, but that isn't the case unless
> something changed recently.

They are all hidden, but there is no real reason for that I think
(other than the samsung glitch).

Having them inside the menu makes it possible to add '|| COMPILE_TEST'
as a follow-up, and makes it more consistent overall.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section Stephen Boyd <sboyd@codeaurora.org> - 2016-01-28 09:40 +0100
  Re: [PATCH] clk: Move vendor's Kconfig into CCF menu section Arnd Bergmann <arnd@arndb.de> - 2016-01-28 12:40 +0100

csiph-web