Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320492

Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

Path csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024
Date Thu, 28 Jan 2016 11:10:02 +0100
Message-ID <qVRGy-1R3-5@gated-at.bofh.it> (permalink)
References <qSBRE-6uw-3@gated-at.bofh.it> <qSBRD-6uw-1@gated-at.bofh.it>
X-Original-To Laxman Dewangan <ldewangan@nvidia.com>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=I0I+PaVcKpWjm2fIvhx20wgO263yU6FVhNvirhGYGpE=; b=VHSPLk0u+wJztfdW9EiMiop1uem1r9Nc23/dWBj4zkBXrRB6NnxcRDMrrmlIzLsSzC SQ6W81elbvdz0NM9JCcd7P/kV6ZhdbcwpOflTkpNTjla1uQr1Wpy8W2zrL9UboJ3SnAw 0J+WpSOoxAYwncJZo4XOh2+OIwEIoVeGxtcKI=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=I0I+PaVcKpWjm2fIvhx20wgO263yU6FVhNvirhGYGpE=; b=ORsTvFjoPmEKGvz5BV9WuxBzrlVqWg+VL/9bDfZnefULADlai7Hb07qpQ5NcuYMPmq Khyn9esk60C5sIYrA+GK2+s12qsONgswd11MuU1aLfZemJd3m9ZxuHoy6rP6t3lSBh65 vkMpmaYv/ju57iiCdjdvpAHL6U2tKXAxhyTATdOJQ2urt7R9tqfqj5/hsn2/emLLAwgN vkuQvTIT0amezD3cDGvU7v6D51KmK01GucLeZahT+ydPgaW8PMN1ffbqa8tc7iOOl2ly lgquOaFtL8wINdYp12ObOJkOz+reA2ZWQubvh4JaxMokjXuCbPBjp/v80Smc5LiIRO8N Q3Aw==
X-Gm-Message-State AG10YOQLToxQVXeeAUIUoIVBv8y0sg094sMp4aQ8ikRvZQ/8X32S4ldfRbUUs4wiWMS6jWdaPMnH1GFxezxYZVXu
MIME-Version 1.0
X-Received by 10.182.39.193 with SMTP id r1mr1448972obk.21.1453975450780; Thu, 28 Jan 2016 02:04:10 -0800 (PST)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 24
Organization linux.* mail to news gateway
X-Original-Cc Rob Herring <robh+dt@kernel.org>, Paweł Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, "ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alexandre Courbot <gnurou@gmail.com>, Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>, Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@free-electrons.com>, Liam Girdwood <lgirdwood@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "rtc-linux@googlegroups.com" <rtc-linux@googlegroups.com>, Stephen Warren <swarren@nvidia.com>, Thierry Reding <treding@nvidia.com>, Krzysztof Kozłowski <k.kozlowski@samsung.com>, vreddytalla@nvidia.com, Chaitanya Bandi <bandik@nvidia.com>
X-Original-Date Thu, 28 Jan 2016 11:04:10 +0100
X-Original-Message-ID <CACRpkdZEYw2aADQDNSi0kKns17nKZQZKY+harLhc0j3pA-5FuA@mail.gmail.com>
X-Original-References <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-4-git-send-email-ldewangan@nvidia.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1320492

Show key headers only | View raw


On Tue, Jan 19, 2016 at 11:19 AM, Laxman Dewangan <ldewangan@nvidia.com> wrote:

> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> which also act as the special function in alternate mode. Also
> there is configuration like push-pull, open drain, FPS timing
> etc for these pins.
>
> Add pincontrol driver to configure these parameters through
> pincontrol APIs.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> Signed-off-by: Chaitanya Bandi <bandik@nvidia.com>

Nice. This driver looks like a lot of hard work, but I think
it's worth it.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

I guess Lee will be merging this into the MTD tree.

(I still had those comments on the DT bindings but this driver
part looks fine.)

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-19 11:40 +0100
  Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Linus Walleij <linus.walleij@linaro.org> - 2016-01-28 11:10 +0100
    Re: [PATCH V4 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 11:30 +0100

csiph-web