Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320468

Re: [PATCH] perf data: Fix releasing event_class

Show all headers | View raw

On Thu, Jan 28, 2016 at 04:59:51PM +0800, Wangnan (F) wrote:
> Hi Jiri, What's your opinion on this patch?

> 
> Thank you.
> 
> On 2016/1/27 19:21, Wang Nan wrote:
> >A new patch of libbabeltrace [1] reveals a object leak problem in
> >perf data CTF support: perf code never release event_class which is
> >allocated in add_event() and stored in evsel's private field.
> >
> >If libbabeltrace has the above patch applied, leaking event_class
> >prevent writer being destroied and flushing metadata. For example:

oops, missed this one.. sry.. nice feature ;-)

> >
> >  $ ./perf record ls
> >  Lowering default frequency rate to 500.
> >  Please consider tweaking /proc/sys/kernel/perf_event_max_sample_rate.
> >  perf.data
> >  [ perf record: Woken up 1 times to write data ]
> >  [ perf record: Captured and wrote 0.012 MB perf.data (12 samples) ]
> >  $ ./perf data convert --to-ctf ./out.ctf
> >  [ perf data convert: Converted 'perf.data' into CTF data './out.ctf' ]
> >  [ perf data convert: Converted and wrote 0.000 MB (12 samples) ]
> >  $ cat ./out.ctf/metadata
> >  $ ls -l  ./out.ctf/metadata
> >  -rw-r----- 1 w00229757 mm 0 Jan 27 10:49 ./out.ctf/metadata

SNIP

> >+static void cleanup_events(struct perf_session *session)
> >+{
> >+	struct perf_evlist *evlist = session->evlist;
> >+	struct perf_evsel *evsel;
> >+
> >+	evlist__for_each(evlist, evsel) {
> >+		struct evsel_priv *priv;
> >+
> >+		priv = evsel->priv;
> >+		bt_ctf_event_class_put(priv->event_class);

right, we missed that.. but we should also call free(priv) then

also I can't see also perf_evlist__delete being called..
not sure perf_session__delete will take care of that

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf data: Fix releasing event_class Wang Nan <wangnan0@huawei.com> - 2016-01-27 12:30 +0100
  Re: [PATCH] perf data: Fix releasing event_class "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-28 10:10 +0100
    Re: [PATCH] perf data: Fix releasing event_class Jiri Olsa <jolsa@redhat.com> - 2016-01-28 10:30 +0100
      [PATCH v2] perf data: Fix releasing event_class Wang Nan <wangnan0@huawei.com> - 2016-01-28 14:30 +0100
        Re: [PATCH v2] perf data: Fix releasing event_class Jiri Olsa <jolsa@redhat.com> - 2016-01-28 16:00 +0100
          Re: [PATCH v2] perf data: Fix releasing event_class Arnaldo Carvalho de Melo <acme@redhat.com> - 2016-01-28 20:10 +0100
            Re: [PATCH v2] perf data: Fix releasing event_class Jiri Olsa <jolsa@redhat.com> - 2016-01-28 20:50 +0100

csiph-web