Groups > linux.kernel > #1320420

Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc

From	Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc
Date	2016-01-28 09:40 +0100
Message-ID	<qVQht-Jf-25@gated-at.bofh.it> (permalink)
References	<qVAZ3-6ax-3@gated-at.bofh.it> <qVAZ3-6ax-1@gated-at.bofh.it> <qVQhs-Jf-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 28/01/2016 at 00:33:47 -0800, Stephen Boyd wrote :
> On 01/27, Alexandre Belloni wrote:
> > @@ -399,13 +400,33 @@ static void __init at91_pm_sram_init(void)
> >  			&at91_pm_suspend_in_sram, at91_pm_suspend_in_sram_sz);
> >  }
> >  
> > +static __initconst struct of_device_id atmel_pmc_ids[] = {
> 
> The kbuild error is weird, but __initconst should come right
> before the equals sign (=). Plus it should actually be const.
> 

Yeah, I sent v5, right after v4. I had that change but forgot to squash
it.

> > +	{ .compatible = "atmel,at91rm9200-pmc"  },
> > +	{ .compatible = "atmel,at91sam9260-pmc" },
> > +	{ .compatible = "atmel,at91sam9g45-pmc" },
> > +	{ .compatible = "atmel,at91sam9n12-pmc" },
> > +	{ .compatible = "atmel,at91sam9x5-pmc" },
> > +	{ .compatible = "atmel,sama5d3-pmc" },
> > +	{ .compatible = "atmel,sama5d2-pmc" },
> > +	{ /* sentinel */ },
> > +};
> > +
> >  static void __init at91_pm_init(void)
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 07/13] ARM: at91: pm: find and remap the pmc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-27 17:20 +0100
  [PATCH v5 07/13] ARM: at91: pm: find and remap the pmc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-27 17:30 +0100
  Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc kbuild test robot <lkp@intel.com> - 2016-01-27 19:00 +0100
  Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc Stephen Boyd <sboyd@codeaurora.org> - 2016-01-28 09:40 +0100
    Re: [PATCH v4 07/13] ARM: at91: pm: find and remap the pmc Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-01-28 09:40 +0100

csiph-web