Groups > linux.kernel > #1320442

Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency
Date	2016-01-28 10:00 +0100
Message-ID	<qVQAO-Qb-9@gated-at.bofh.it> (permalink)
References	<qVyXg-4EQ-3@gated-at.bofh.it> <qVyXg-4EQ-1@gated-at.bofh.it> <qVAZ6-6ax-67@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 27 January 2016 11:11:10 Paul Gortmaker wrote:
> [[PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency] On 27/01/2016 (Wed 15:04) Arnd Bergmann wrote:
> 
> > The bgmac driver depends on BCMA_HOST_SOC, which is only used
> > when CONFIG_BCMA is enabled. However, it is a bool option and can
> > be set when CONFIG_BCMA=m, and then bgmac can be built-in, leading
> > to an obvious link error:
> > 
> > drivers/built-in.o: In function `bgmac_init':
> > :(.init.text+0x7f2c): undefined reference to `__bcma_driver_register'
> > drivers/built-in.o: In function `bgmac_exit':
> > :(.exit.text+0x110a): undefined reference to `bcma_driver_unregister'
> > 
> > To avoid this case, we need to depend on both BCMA and BCMA_SOC,
> > as this patch does. I'm also trying to make the dependency more
> > readable by splitting it into three lines, and adding a COMPILE_TEST
> > alternative so we can test-build it in all configurations that
> > support BCMA.
> 
> It wasn't immediately clear to me from the above why you added the
> select on FIXED_PHY.
> 

Right, I'll resend the patch with improved changelog. This series
is mostly patches for old and rare randconfig bugs, so I had built
thousands of configurations and fixed up everything until new warnings
or errors kept coming up. The FIXED_PHY error came up in the same
driver so I merged the two patches but did not notice how the changelog
failed to explain it.

Thanks,

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-27 15:10 +0100
  Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-01-27 17:20 +0100
    Re: [PATCH 3/9] net: bgmac: clarify CONFIG_BCMA dependency Arnd Bergmann <arnd@arndb.de> - 2016-01-28 10:00 +0100

csiph-web