Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320287

Re: [PATCH 16/16] mm/slab: introduce new slab management type, OBJFREELIST_SLAB

Show all headers | View raw

On Wed, Jan 27, 2016 at 02:35:04PM +0100, Vlastimil Babka wrote:
> On 01/14/2016 06:24 AM, Joonsoo Kim wrote:
> > In fact, I tested another idea implementing OBJFREELIST_SLAB with
> > extendable linked array through another freed object. It can remove
> > memory waste completely but it causes more computational overhead
> > in critical lock path and it seems that overhead outweigh benefit.
> > So, this patch doesn't include it.
> 
> Can you elaborate? Do we actually need an extendable linked array? Why not just
> store the pointer to the next free object into the object, NULL for the last
> one? I.e. a singly-linked list. We should never need to actually traverse it?

As Christoph explained, it's the way SLUB manages freed objects. In SLAB
case, it doesn't want to touch object itself. It's one of main difference
between SLAB and SLUB. These objects are cache-cold now so touching object itself
could cause more cache footprint.

> 
> freeing object obj:
> *obj = page->freelist;
> page->freelist = obj;
> 
> allocating object:
> obj = page->freelist;
> page->freelist = *obj;
> *obj = NULL;
> 
> That means two writes, but if we omit managing page->active, it's not an

It's not just matter of number of instructions as explained above. Touching
more cache line should also be avoided.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 16/16] mm/slab: introduce new slab management type,  OBJFREELIST_SLAB Vlastimil Babka <vbabka@suse.cz> - 2016-01-27 14:40 +0100
  Re: [PATCH 16/16] mm/slab: introduce new slab management type,  OBJFREELIST_SLAB Christoph Lameter <cl@linux.com> - 2016-01-27 17:50 +0100
    Re: [PATCH 16/16] mm/slab: introduce new slab management type,  OBJFREELIST_SLAB Vlastimil Babka <vbabka@suse.cz> - 2016-01-27 18:20 +0100
      Re: [PATCH 16/16] mm/slab: introduce new slab management type,  OBJFREELIST_SLAB Christoph Lameter <cl@linux.com> - 2016-01-27 19:00 +0100
  Re: [PATCH 16/16] mm/slab: introduce new slab management type,  OBJFREELIST_SLAB Joonsoo Kim <iamjoonsoo.kim@lge.com> - 2016-01-28 06:00 +0100
    Re: [PATCH 16/16] mm/slab: introduce new slab management type,  OBJFREELIST_SLAB Vlastimil Babka <vbabka@suse.cz> - 2016-01-29 16:30 +0100

csiph-web