Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320266

Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Doug Anderson <dianders@chromium.org>
Newsgroups linux.kernel
Subject Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066
Date Thu, 28 Jan 2016 04:30:01 +0100
Message-ID <qVLrr-5At-1@gated-at.bofh.it> (permalink)
References <qTOtr-7NF-11@gated-at.bofh.it> <qTOD9-7Rf-31@gated-at.bofh.it> <qVLhM-5vZ-29@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=RuEto1SmeZuUipNmtoXy3Jg3kxkYMdefJTknI/LQsu8=; b=pfikjlHf9iphi/+PvlEaSvKnR12QkJPs9TLMGtW1NPo0d9tzVHhh8XFNbAezDVggrf ri5yOoycHxMagsan4Ia8reI59p8ar0u2oWInrkKzGOcVauGjfc7hzMFqxQRa7z4ocdZq Rly+ahb/lx4H2RF3s9C1BIhRaGJR4/g4o5CJqrg8WYJsprEVzCRu0oGZdAY5ZLB4dmaU p17J4rSXz/hXD2IKCVHvWKo73zsFbYX5pJSX25aS3dEXeHVygcNMn/bxI1ltLGFCfnrg oruMrPLjxm9xqx0KTZYl0EaeAyQ/SmIIDZlNSTTsrQp57zf29uJiojKlWHnSOH4+FaLr VIpw==
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=RuEto1SmeZuUipNmtoXy3Jg3kxkYMdefJTknI/LQsu8=; b=TicKXXyTAG6bGx+hXBmUx0/TgNflOk49O/LrX5YjoRjvGRcBFOpprbAkdPGCW2LgGF FS5odxQ1yks8rDcyYxz2f1rrCykA0UKiVQ8z/G81QjtOdPgB+gRjUrCZIO/I1Sicz6AG /YwxGU+MgM7tFnltcYLO5hM1gnB6nZcs4p2U0=
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=RuEto1SmeZuUipNmtoXy3Jg3kxkYMdefJTknI/LQsu8=; b=e8Tm30fwkGcv5HH0jbVXnuGaHyMH/Wg6+r/m1HCMXKFkD8hfePvIownQyAnnH5oAlg Hkdg4aWNvG/iW3npyGhlCMAY2W6uiHmSyrSAbUfGPkzD2raSFnlpPtKiEWsL2NhEwMfP ykERTw0WM4U81/+yz7qIX+qOSiv8O/uSdRWGEz457APyOpJpJXnpliWZW8V6pU0eYbvF tQc2vZrGm53Sdb1s9E3GCxqVvdpQMK9NfDD5eVUMQoj3JAVT2myda8qg3wm00u2DWJLF 5c5osTF3jAHTSy8FW/SLqm7qStvtZJ5iYjb0NXsptZgWQOGuxHkPAMYReLsjkivy90lQ duzg==
X-Gm-Message-State AG10YORr0Cro68ipY+627182CBYpl22d3wChdjjhDGoAJ04QIgzuKwlF4XOz/f2g4eaJ0HFXJqZRK51W+1xRzxWN
MIME-Version 1.0
X-Received by 10.37.55.76 with SMTP id e73mr385120yba.39.1453951738531; Wed, 27 Jan 2016 19:28:58 -0800 (PST)
X-Google-Sender-Auth SLSvMseC-JoTKsocU81NYoklexk
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 33
Organization linux.* mail to news gateway
X-Original-Cc John Youn <John.Youn@synopsys.com>, Felipe Balbi <balbi@ti.com>, Tao Huang <huangtao@rock-chips.com>, "Herrero, Gregory" <gregory.herrero@intel.com>, Heiko Stübner <heiko@sntech.de>, John Youn <johnyoun@synopsys.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Ming Lei <ming.lei@canonical.com>, "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, "Kaukab, Yousaf" <yousaf.kaukab@intel.com>, Alan Stern <stern@rowland.harvard.edu>, 吴良峰 <william.wu@rock-chips.com>, Julius Werner <jwerner@chromium.org>, Dinh Nguyen <dinguyen@opensource.altera.com>
X-Original-Date Wed, 27 Jan 2016 19:28:58 -0800
X-Original-Message-ID <CAD=FV=VAkY0ijkUBrgjY04+OfYq35u=MbqbbomeQxp_J179iHw@mail.gmail.com>
X-Original-References <1453486736-15358-1-git-send-email-dianders@chromium.org> <1453486736-15358-5-git-send-email-dianders@chromium.org> <56A986B4.2050002@rock-chips.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1320266

Show key headers only | View raw


Kever,

On Wed, Jan 27, 2016 at 7:10 PM, Kever Yang <kever.yang@rock-chips.com> wrote:
> Hi Doug,
>
> We are using the minimum FIFO size mode for TX now, which only
> equal to one max packet size.
>
> The addition FIFO size may help shorten the inter-packet data
> prepare latency when the bus/DRAM is busy.
>
> For the actual usage in TX, we have very little change to use the
> period TX FIFO with more than one max packet size in host mode.
> So far as I know, usb audio use the isochronous tx FIFO, but this
> king of device won't have much data payload and won't, I haven't
> see a usb audio have more data than 1024byte/ms.
>
> So I suggest we assign this 48 words to host_nperio_tx_fifi_size instead
> if we have to do this. Because we are using device base on bulk transaction
> like U-disk very frequently.

Try using a USB webcam.  With that plus a USB audio device it's easy
to overwhelm the periodic TX FIFO.

If we overwhelm the periodic TX FIFO we might actually fail to
transmit ISO or INT packets at the scheduled time.  That seems more
serious of a problem to try to fix than eeking out a tiny bit
performance on a USB disk.  ...but of course, it all depends on what
you consider important.  ;)

We could split the difference, I suppose and put half on each?

-Doug

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066 Douglas Anderson <dianders@chromium.org> - 2016-01-22 19:30 +0100
  Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size  to 304 for rk3066 Kever Yang <kever.yang@rock-chips.com> - 2016-01-28 04:20 +0100
    Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to  304 for rk3066 Doug Anderson <dianders@chromium.org> - 2016-01-28 04:30 +0100
      Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size  to 304 for rk3066 Kever Yang <kever.yang@rock-chips.com> - 2016-01-28 07:50 +0100
        Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to  304 for rk3066 Doug Anderson <dianders@chromium.org> - 2016-01-28 19:20 +0100
          Re: [PATCH v5 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to  304 for rk3066 Doug Anderson <dianders@chromium.org> - 2016-01-29 00:30 +0100

csiph-web