Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320225

Re: [PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data

From Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data
Date 2016-01-28 03:20 +0100
Message-ID <qVKlH-4HL-7@gated-at.bofh.it> (permalink)
References <qUSOo-7cE-51@gated-at.bofh.it> <qVHeb-2ip-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 27-01-16, 23:54, Rafael J. Wysocki wrote:
> So I've applied this, but I'm not sure it is sufficient yet.

At least, this solves the crash Juri was hitting on a multi cluster
box.

> Have you double checked whether or not stuff cannot be reordered by
> the CPU and/or the compiler and no additional memory barriers are needed?

I don't think CPU will reorder things before a function call. It can
reorder lines, which CPU thinks aren't related but it can't assume the
same in this case. We have tons of code like this.

@Juri: What do you say? 

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-25 18:10 +0100
  Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Juri Lelli <juri.lelli@arm.com> - 2016-01-26 11:00 +0100
    Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Juri Lelli <juri.lelli@arm.com> - 2016-01-26 19:10 +0100
      Re: [PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-26 23:50 +0100
        Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Juri Lelli <juri.lelli@arm.com> - 2016-01-27 11:30 +0100
      Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-27 04:20 +0100
    Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-27 04:20 +0100
      Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Juri Lelli <juri.lelli@arm.com> - 2016-01-27 11:20 +0100
  Re: [PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-28 00:00 +0100
    Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Viresh Kumar <viresh.kumar@linaro.org> - 2016-01-28 03:20 +0100
      Re: [PATCH] cpufreq: Fix NULL reference crash while accessing  policy->governor_data Juri Lelli <juri.lelli@arm.com> - 2016-01-28 11:50 +0100
      Re: [PATCH] cpufreq: Fix NULL reference crash while accessing policy->governor_data "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-29 04:40 +0100

csiph-web