Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320233
| From | Henry Chen <henryc.chen@mediatek.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct |
| Date | 2016-01-28 03:40 +0100 |
| Message-ID | <qVKF4-4Q6-7@gated-at.bofh.it> (permalink) |
| References | <qVwsq-2JC-15@gated-at.bofh.it> <qVwsq-2JC-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi John,
On Wed, 2016-01-27 at 12:29 +0100, John Crispin wrote:
> @@ -746,7 +786,7 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> pwrap_writel(wrp, 1, PWRAP_DIO_EN);
>
> /* Read Test */
> - pwrap_read(wrp, PWRAP_DEW_READ_TEST, &rdata);
> + pwrap_dew_read(wrp, PWRAP_DEW_READ_TEST, &rdata);
> if (rdata != PWRAP_DEW_READ_TEST_VAL) {
> dev_err(wrp->dev, "Read test failed after switch to DIO mode: 0x%04x != 0x%04x\n",
> PWRAP_DEW_READ_TEST_VAL, rdata);
> @@ -759,12 +799,13 @@ static int pwrap_init(struct pmic_wrapper *wrp)
> return ret;
>
> /* Signature checking - using CRC */
> - if (pwrap_write(wrp, PWRAP_DEW_CRC_EN, 0x1))
> + if (pwrap_dew_write(wrp, PWRAP_DEW_CRC_EN, 0x1))
> return -EFAULT;
>
> pwrap_writel(wrp, 0x1, PWRAP_CRC_EN);
> pwrap_writel(wrp, 0x0, PWRAP_SIG_MODE);
> - pwrap_writel(wrp, PWRAP_DEW_CRC_VAL, PWRAP_SIG_ADR);
> + pwrap_writel(wrp, wrp->slave->dew_regs[PWRAP_DEW_CRC_VAL],
> + PWRAP_SIG_ADR);
It should be "pwrap_dew_write(wrp, PWRAP_DEW_CRC_VAL, PWRAP_SIG_ADR);",
right?
Henry
> pwrap_writel(wrp, wrp->master->arb_en_all, PWRAP_HIPRIO_ARB_EN);
>
> if (wrp->master->type == PWRAP_MT8135)
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct John Crispin <blogic@openwrt.org> - 2016-01-27 12:30 +0100
Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct Henry Chen <henryc.chen@mediatek.com> - 2016-01-28 03:40 +0100
Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct John Crispin <blogic@openwrt.org> - 2016-02-01 09:30 +0100
Re: [PATCH V4 09/11] soc: mediatek: PMIC wrap: add a slave specific struct Henry Chen <henryc.chen@mediatek.com> - 2016-02-01 09:40 +0100
csiph-web