Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1320174

[PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7

From Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups linux.kernel
Subject [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7
Date 2016-01-28 01:40 +0100
Message-ID <qVIMW-3vP-21@gated-at.bofh.it> (permalink)
References <qVIMV-3vP-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Currently the Exynos5433 (ARMv8 SoC) clock driver depends on ARCH_EXYNOS
so it is built also on ARMv7. This does not bring any kind of benefit.
There won't be a single kernel image for ARMv7 and ARMv8 SoCs (like
multi_v7 for ARMv7).

Instead build clock drivers only for respective SoC's architecture.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

Changes since v3:
1. Rebase on next-20160127.

Changes since v2:
1. Follow Arnd's advice making EXYNOS_ARM64_COMMON_CLK user-visible when
   COMPILE_TEST is enabled.
2. Dropped accumulated tags because the logic is now different.

Changes since v1:
1. Use one Kconfig symbol for clocks of all ARM64 SoCs (after
   discussion): EXYNOS_ARM64_COMMON_CLK.
2. Minor cleanups after Tomasz's comments.
3. Added tags: Chanwoo's, Sylwester's, Alim's and Tomasz's (the tags
   were given for v1 but assuming that change from 1. is not major
   enough to require re-tagging).
---
 drivers/clk/samsung/Kconfig  | 5 +++++
 drivers/clk/samsung/Makefile | 4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig
index dd6093a33f84..5fd982d9f4d9 100644
--- a/drivers/clk/samsung/Kconfig
+++ b/drivers/clk/samsung/Kconfig
@@ -23,3 +23,8 @@ config S3C2443_COMMON_CLK
 	bool "Samsung S3C2443 clock controller support" if COMPILE_TEST
 	select COMMON_CLK_SAMSUNG
 
+# ARM64 SoCs (e.g. Exynos5433, Exynos7):
+config EXYNOS_ARM64_COMMON_CLK
+	bool "Samsung Exynos ARMv8-family clock controller support" if COMPILE_TEST
+	default ARM64 && COMMON_CLK_SAMSUNG
+	depends on (ARM64 && COMMON_CLK_SAMSUNG) || COMPILE_TEST
diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
index 5f6833ea355d..fc367d4b2902 100644
--- a/drivers/clk/samsung/Makefile
+++ b/drivers/clk/samsung/Makefile
@@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250)	+= clk-exynos5250.o
 obj-$(CONFIG_SOC_EXYNOS5260)	+= clk-exynos5260.o
 obj-$(CONFIG_SOC_EXYNOS5410)	+= clk-exynos5410.o
 obj-$(CONFIG_SOC_EXYNOS5420)	+= clk-exynos5420.o
-obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos5433.o
+obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos5433.o
 obj-$(CONFIG_SOC_EXYNOS5440)	+= clk-exynos5440.o
 obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos-audss.o
 obj-$(CONFIG_ARCH_EXYNOS)	+= clk-exynos-clkout.o
-obj-$(CONFIG_ARCH_EXYNOS7)	+= clk-exynos7.o
+obj-$(CONFIG_EXYNOS_ARM64_COMMON_CLK)	+= clk-exynos7.o
 obj-$(CONFIG_S3C2410_COMMON_CLK)+= clk-s3c2410.o
 obj-$(CONFIG_S3C2410_COMMON_DCLK)+= clk-s3c2410-dclk.o
 obj-$(CONFIG_S3C2412_COMMON_CLK)+= clk-s3c2412.o
-- 
1.9.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-28 01:40 +0100
  [PATCH v4 1/3] clk: samsung: Enable COMPILE_TEST for Samsung clocks Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-28 01:40 +0100
    Re: [PATCH v4 1/3] clk: samsung: Enable COMPILE_TEST for Samsung  clocks Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-28 20:20 +0100
    Re: [PATCH v4 1/3] clk: samsung: Enable COMPILE_TEST for Samsung  clocks Stephen Boyd <sboyd@codeaurora.org> - 2016-01-29 21:50 +0100
  [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on ARMv7 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-28 01:40 +0100
    Re: [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on  ARMv7 Chanwoo Choi <cw00.choi@samsung.com> - 2016-01-28 02:30 +0100
    Re: [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on  ARMv7 Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-28 20:20 +0100
    Re: [PATCH v4 2/3] clk: samsung: Don't build ARMv8 clock drivers on  ARMv7 Stephen Boyd <sboyd@codeaurora.org> - 2016-01-29 21:50 +0100
  [PATCH v4 3/3] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol into  ARCH_EXYNOS Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-28 01:40 +0100
    Re: [PATCH v4 3/3] arm64: EXYNOS: Consolidate ARCH_EXYNOS7 symbol  into ARCH_EXYNOS Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-28 20:20 +0100
  Re: [PATCH v4 0/3] arm64/clk: EXYNOS: Consolidate Exynos7 symbol Andi Shyti <andi.shyti@samsung.com> - 2016-01-29 02:20 +0100

csiph-web