Groups > linux.kernel > #1320149

Re: [PATCH] input: xpad: remove unused function

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] input: xpad: remove unused function
Date	2016-01-28 00:50 +0100
Message-ID	<qVI0y-2V1-7@gated-at.bofh.it> (permalink)
References	<qURpg-60C-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 25, 2016 at 04:30:41PM +0100, Arnd Bergmann wrote:
> There are two definitions of xpad_identify_controller(), one is used
> when CONFIG_JOYSTICK_XPAD_LEDS is set, but the other one is empty
> and never used, and we get a gcc warning about it:
> 
> drivers/input/joystick/xpad.c:1210:13: warning: 'xpad_identify_controller' defined but not used [-Wunused-function]
> 
> This removes the second definition.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: cae705baa40b ("Input: xpad - re-send LED command on present event")

Applied, thank you.

> ---
>  drivers/input/joystick/xpad.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 6727954ab74b..e8a84d12b7ff 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -1207,7 +1207,6 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
>  #else
>  static int xpad_led_probe(struct usb_xpad *xpad) { return 0; }
>  static void xpad_led_disconnect(struct usb_xpad *xpad) { }
> -static void xpad_identify_controller(struct usb_xpad *xpad) { }
>  #endif
>  
>  static int xpad_start_input(struct usb_xpad *xpad)
> -- 
> 2.7.0
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] input: xpad: remove unused function Arnd Bergmann <arnd@arndb.de> - 2016-01-25 16:40 +0100
  Re: [PATCH] input: xpad: remove unused function Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-28 00:50 +0100

csiph-web