Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320151

Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings

Show all headers | View raw

On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Wed, 27 Jan 2016, Arnd Bergmann wrote:
> 
> > The proc_create() and remove_proc_entry() functions do not reference
> > their arguments when CONFIG_PROC_FS is disabled, so we get a couple
> > of warnings about unused variables in IPVS:
> > 
> > ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3950:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3994:14: warning: unused variable 'net' [-Wunused-variable]
> > 
> > This removes the local variables and instead looks them up separately
> > for each use, which obviously avoids the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 4c50a8ce2b63 ("netfilter: ipvs: avoid unused variable warning")
> 
> 	Looks like your previous patch for ip_vs_app_net_cleanup
> was delayed in ipvs-next tree. I guess, Simon should drop it and
> use this one instead when net-next opens:
> 
> Acked-by: Julian Anastasov <ja@ssi.bg>

Thanks, and sorry about not pushing the other patch to net-next.
I have dropped it and queued up this one in its place.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Arnd Bergmann <arnd@arndb.de> - 2016-01-27 15:00 +0100
  [PATCH 2/2] netfilter: ipvs/SIP: handle ip_vs_fill_iph_skb_off failure Arnd Bergmann <arnd@arndb.de> - 2016-01-27 15:00 +0100
    Re: [PATCH 2/2] netfilter: ipvs/SIP: handle ip_vs_fill_iph_skb_off  failure Julian Anastasov <ja@ssi.bg> - 2016-01-27 22:10 +0100
      Re: [PATCH 2/2] netfilter: ipvs/SIP: handle ip_vs_fill_iph_skb_off  failure Simon Horman <horms@verge.net.au> - 2016-01-28 00:40 +0100
  Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Julian Anastasov <ja@ssi.bg> - 2016-01-27 21:20 +0100
    Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Simon Horman <horms@verge.net.au> - 2016-01-28 00:50 +0100
      Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings Arnd Bergmann <arnd@arndb.de> - 2016-01-28 13:40 +0100

csiph-web