Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320111
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | "K. Y. Srinivasan" <kys@microsoft.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH 04/13] Drivers: hv: vmbus: don't manipulate with clocksources on crash |
| Date | Thu, 28 Jan 2016 00:00:04 +0100 |
| Message-ID | <qVHec-2ip-45@gated-at.bofh.it> (permalink) |
| References | <qVHea-2ip-5@gated-at.bofh.it> <qVHea-2ip-7@gated-at.bofh.it> |
| X-Original-To | gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com |
| X-Originating-IP | 72.167.245.219 |
| X-Mailer | git-send-email 1.7.4.1 |
| X-Cmae-Envelope | MS4wfHTTOf3ujQtMVUv2bDrzddDVMWI6UbAuCWdA8PyXhHSOjL7XS4ddBgv1056AEEsxb0Igz5iUs6/AlstSvP3cHRb0lI7ecsOPREq4z2YDIh5+eKPs7cr8 oZ39xrNO3KwtmwPZfP0loVLCOXCVHmUPA3DAN6lucpx0bYIjdYrxu3QAIKIYMjeycQKnXWFxPVXDkSXabV2wvgL9wHDXmr0RPgY5vdev8PSKE584ppVEW7Bq RI1KuIb7rX6gw/ZQ6aG2N/bfPLemmUzjZJlmQ7fbfEGviorsURS9mi44CUDx/Dzj86XQheV+UNkRl3K3ZmfntuS/hhezEFL3LzE+0AbCyhbnuZtuRESVxSg0 EEC+2C6R4+1yxb+yZJyu6NuOxgyq8CZ/MS+iJKXZAfR8CvQmkYzYPSa6NDy3/G0e4eHdeHiS |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 35 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | "K. Y. Srinivasan" <kys@microsoft.com> |
| X-Original-Date | Wed, 27 Jan 2016 16:26:46 -0800 |
| X-Original-Message-ID | <1453940815-26096-4-git-send-email-kys@microsoft.com> |
| X-Original-References | <1453940792-25878-1-git-send-email-kys@microsoft.com> <1453940815-26096-1-git-send-email-kys@microsoft.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1320111 |
Show key headers only | View raw
From: Vitaly Kuznetsov <vkuznets@redhat.com>
clocksource_change_rating() involves mutex usage and can't be called
in interrupt context. It also makes sense to avoid doing redundant work
on crash.
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/hv.c | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 11bca51..257de21 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -295,8 +295,14 @@ void hv_cleanup(void)
* Cleanup the TSC page based CS.
*/
if (ms_hyperv.features & HV_X64_MSR_REFERENCE_TSC_AVAILABLE) {
- clocksource_change_rating(&hyperv_cs_tsc, 10);
- clocksource_unregister(&hyperv_cs_tsc);
+ /*
+ * Crash can happen in an interrupt context and unregistering
+ * a clocksource is impossible and redundant in this case.
+ */
+ if (!oops_in_progress) {
+ clocksource_change_rating(&hyperv_cs_tsc, 10);
+ clocksource_unregister(&hyperv_cs_tsc);
+ }
hypercall_msr.as_uint64 = 0;
wrmsrl(HV_X64_MSR_REFERENCE_TSC, hypercall_msr.as_uint64);
--
1.7.4.1
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/13] tools/hv: Use include/uapi with __EXPORTED_HEADERS__ "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 03/13] Drivers: hv: vmbus: avoid scheduling in interrupt context in vmbus_initiate_unload() "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 05/13] Drivers: hv: vmbus: add a helper function to set a channel's pending send size "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 04/13] Drivers: hv: vmbus: don't manipulate with clocksources on crash "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 13/13] Drivers: hv: vmbus: Give control over how the ring access is serialized "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 02/13] Drivers: hv: vmbus: avoid infinite loop in init_vp_index() "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 12/13] Drivers: hv: vmbus: Eliminate the spin lock on the read path "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 07/13] Drivers: hv: vmbus: vmbus_sendpacket_ctl: hvsock: avoid unnecessary signaling "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100 [PATCH 08/13] Drivers: hv: vmbus: define a new VMBus message type for hvsock "K. Y. Srinivasan" <kys@microsoft.com> - 2016-01-28 00:00 +0100
csiph-web