Groups > linux.kernel > #1319959

Re: [PATCH] HID: rmi: Check that the device is a RMI device in suspend and resume callbacks

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] HID: rmi: Check that the device is a RMI device in suspend and resume callbacks
Date	2016-01-27 22:50 +0100
Message-ID	<qVG8q-1wI-13@gated-at.bofh.it> (permalink)
References	<qVlx0-3bN-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 26 Jan 2016, Andrew Duggan wrote:

> Commit 092563604217 ("HID: rmi: Disable scanning if the device is not a
> wake source") introduced a regression for devices which use hid-rmi to
> handle composite USB devices. The suspend or resume callbacks are not
> checking that the device is a RMI device before calling rmi_read or
> rmi_write. This results in dereferencing uninitialized variables on
> non RMI devices. This patch checks that the RMI_DEVICE flag is set before
> sending RMI commands to the device.
> 
> Reported-by: Rodrigo Gomes <rodrigo.toste.gomes@gmail.com>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>

Applied to for-4.5/upstream-fixes.

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] HID: rmi: Check that the device is a RMI device in suspend and resume callbacks Andrew Duggan <aduggan@synaptics.com> - 2016-01-27 00:50 +0100
  Re: [PATCH] HID: rmi: Check that the device is a RMI device in  suspend and resume callbacks Jiri Kosina <jikos@kernel.org> - 2016-01-27 22:50 +0100

csiph-web