Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1319944

Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller

Show all headers | View raw

On Wed, 27 Jan 2016, Stafford Horne wrote:

> The midi controller times-out while initializing reports, this
> causes boot to take an extra 10 seconds. The device descriptor
> advertises that it has an internal HID device but seems to not
> actually do anything useful.
> 
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>  drivers/hid/hid-ids.h           | 3 +++
>  drivers/hid/usbhid/hid-quirks.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b6ff6e7..3dfb166 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -61,6 +61,9 @@
>  #define USB_VENDOR_ID_AIREN		0x1a2c
>  #define USB_DEVICE_ID_AIREN_SLIMPLUS	0x0002
>  
> +#define USB_VENDOR_ID_AKAI              0x2011
> +#define USB_DEVICE_ID_AKAI_MPKMINI2     0x0715
> +
>  #define USB_VENDOR_ID_ALCOR		0x058f
>  #define USB_DEVICE_ID_ALCOR_USBRS232	0x9720
>  
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 7dd0953..055e740 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -55,6 +55,7 @@ static const struct hid_blacklist {
>  	{ USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
>  
>  	{ USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
> +	{ USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },

If the (proclaimed) HID device is completely silent, wouldn't 
HID_QUIRK_IGNORE be more appropriate?

-- 
Jiri Kosina
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] HID: quirks: Add no_init_reports for AKAI midi controller Stafford Horne <shorne@gmail.com> - 2016-01-27 15:20 +0100
  Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi  controller Jiri Kosina <jikos@kernel.org> - 2016-01-27 22:40 +0100
    Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi  controller Stafford Horne <shorne@gmail.com> - 2016-01-27 23:50 +0100
    Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi  controller Oliver Neukum <oneukum@suse.com> - 2016-01-28 10:20 +0100
      Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi  controller Stafford Horne <shorne@gmail.com> - 2016-01-28 11:10 +0100

csiph-web