Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1319875

[PATCH 0/5] Fix races & improve the radix tree iterator patterns

Show all headers | View raw

From: Matthew Wilcox <willy@linux.intel.com>

The first two patches here are bugfixes, and I would like to see them
make their way into stable ASAP since they can lead to data corruption
(very low probabilty).

The last three patches do not qualify as bugfixes.  They simply improve
the standard pattern used to do radix tree iterations by removing the
'goto restart' part.  Partially this is because this is an ugly &
confusing goto, and partially because with multi-order entries in the
tree, it'll be more likely that we'll see an indirect_ptr bit, and
it's more efficient to kep going from the point of the iteration we're
currently in than restart from the beginning each time.

Matthew Wilcox (5):
  radix-tree: Fix race in gang lookup
  hwspinlock: Fix race between radix tree insertion and lookup
  btrfs: Use radix_tree_iter_retry()
  mm: Use radix_tree_iter_retry()
  radix-tree,shmem: Introduce radix_tree_iter_next()

 drivers/hwspinlock/hwspinlock_core.c |  4 +++
 fs/btrfs/tests/btrfs-tests.c         |  3 +-
 include/linux/radix-tree.h           | 31 +++++++++++++++++++++
 lib/radix-tree.c                     | 12 ++++++--
 mm/filemap.c                         | 53 ++++++++++++------------------------
 mm/shmem.c                           | 30 ++++++++++----------
 6 files changed, 78 insertions(+), 55 deletions(-)

-- 
2.7.0.rc3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/5] Fix races & improve the radix tree iterator patterns Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-27 22:20 +0100
  [PATCH 1/5] radix-tree: Fix race in gang lookup Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-27 22:20 +0100
    Re: [PATCH 1/5] radix-tree: Fix race in gang lookup Konstantin Khlebnikov <koct9i@gmail.com> - 2016-02-03 22:40 +0100
      Re: [PATCH 1/5] radix-tree: Fix race in gang lookup Konstantin Khlebnikov <koct9i@gmail.com> - 2016-02-04 09:50 +0100
  [PATCH 4/5] mm: Use radix_tree_iter_retry() Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-27 22:20 +0100
    Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() Vlastimil Babka <vbabka@suse.cz> - 2016-01-29 15:50 +0100
      Re: [PATCH 4/5] mm: Use radix_tree_iter_retry() Matthew Wilcox <willy@linux.intel.com> - 2016-01-29 16:00 +0100
  Re: [PATCH 0/5] Fix races & improve the radix tree iterator patterns Konstantin Khlebnikov <koct9i@gmail.com> - 2016-01-28 08:20 +0100
    Re: [PATCH 0/5] Fix races & improve the radix tree iterator patterns Konstantin Khlebnikov <koct9i@gmail.com> - 2016-02-03 07:30 +0100

csiph-web