Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1319668

Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file

Show all headers | View raw

Hi Emil,

2016-01-27 Emil Velikov <emil.l.velikov@gmail.com>:

> Hi Gustavo,
> 
> On 27 January 2016 at 17:03, Gustavo Padovan <gustavo@padovan.org> wrote:
> > Hi Maarten,
> >
> > 2016-01-27 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>:
> >
> >> Hey,
> >>
> >> Op 27-01-16 om 14:30 schreef Gustavo Padovan:
> >> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >> >
> >> > sync_file is useful to connect one or more fences to the file. The file is
> >> > used by userspace to track fences.
> >> >
> >> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> >> >
> >> Is there a value in keeping the abi unchanged?
> >> If not, then Documentation/ioctl/botching-up-ioctls.txt is worth a read.
> >
> > None from me. I'll look where we can improve the ABI.
> >
> Speaking of ABI... there are a couple of things that rang bells here:
>  - In most/all of the kernel a len/size named member variable
> indicates the length of the extra data (zero sized array). While here
> it includes the size of the struct as well.

len in this case is the size of the buffer sent to the kernel,
the total length (including the whole struct) is returned in the ioctl.

>  - struct sync_file_info_data::fence_info is of type __u8 yet it is "a
> fence_info struct for every fence in the sync_file". Thus shouldn't
> one use "struct fence_info" as the type ?

Agreed. But I'm currently thinking if we really should keep this ioctl. 

	Gustavo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Gustavo Padovan <gustavo@padovan.org> - 2016-01-27 14:40 +0100
  Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-01-27 15:40 +0100
    Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Gustavo Padovan <gustavo@padovan.org> - 2016-01-27 18:10 +0100
      Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Emil Velikov <emil.l.velikov@gmail.com> - 2016-01-27 19:20 +0100
        Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Gustavo Padovan <gustavo@padovan.org> - 2016-01-27 21:30 +0100
          Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Greg Hackmann <ghackmann@google.com> - 2016-01-27 22:50 +0100
            Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Daniel Vetter <daniel@ffwll.ch> - 2016-01-28 10:30 +0100
              Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file Greg Hackmann <ghackmann@google.com> - 2016-01-29 18:50 +0100

csiph-web