Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1319176

Re: [PATCH RFC 06/11] clk: sunxi: factors: Consolidate get_factors parameters into a struct

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 25, 2016 at 09:15:42PM +0800, Chen-Yu Tsai wrote:
> The .get_factors callback of factors_clk has 6 parameters. To extend
> factors_clk in any way that requires adding parameters to .get_factors
> would make that list even longer, not to mention changing all the
> function declarations.
> 
> Do this once now and consolidate all the parameters into a struct.
> Also drop the space before function pointer arguments, since checkpatch
> complains.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RFC 06/11] clk: sunxi: factors: Consolidate get_factors parameters into a struct Chen-Yu Tsai <wens@csie.org> - 2016-01-25 14:20 +0100
  Re: [PATCH RFC 06/11] clk: sunxi: factors: Consolidate get_factors  parameters into a struct Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-01-27 18:40 +0100

csiph-web