Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1319202

Re: [PATCH RFC 04/11] clk: sunxi: factors: Add unregister function

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH RFC 04/11] clk: sunxi: factors: Add unregister function
Date 2016-01-27 19:10 +0100
Message-ID <qVCHw-7xR-17@gated-at.bofh.it> (permalink)
References <qUPdL-4ol-3@gated-at.bofh.it> <qUPdO-4ol-53@gated-at.bofh.it> <qVAFJ-5LQ-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 27, 2016 at 04:52:10PM +0100, Maxime Ripard wrote:
> On Mon, Jan 25, 2016 at 09:15:40PM +0800, Chen-Yu Tsai wrote:
> > sunxi's factors clk did not have an unregister function. This means
> > multiple structs were leaked whenever a factors clk was unregistered.
> > 
> > Add an unregister function for it. Also keep pointers to the mux and
> > gate structs so they can be freed.
> > 
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> 
> Applied, thanks!
> Maxime

So, yeah, that obviously didn't work, since clk_unregister_composite
wasn't in.

I want to give that as much linux-next coverage as possible, so I
still pulled 3, 5 and 11, replacing the call to
clk_unregister_composite by clk_unregister, adding a todo note on top.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH RFC 04/11] clk: sunxi: factors: Add unregister function Chen-Yu Tsai <wens@csie.org> - 2016-01-25 14:20 +0100
  Re: [PATCH RFC 04/11] clk: sunxi: factors: Add unregister function Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-01-27 17:00 +0100
    Re: [PATCH RFC 04/11] clk: sunxi: factors: Add unregister function Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-01-27 19:10 +0100

csiph-web