Groups > linux.kernel > #1319165

Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Damien Horsley <Damien.Horsley@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio card
Date	Wed, 27 Jan 2016 18:20:01 +0100
Message-ID	<qVBV7-6Sx-3@gated-at.bofh.it> (permalink)
References	<qVzJE-4Zj-15@gated-at.bofh.it> <qVzJE-4Zj-17@gated-at.bofh.it> <qVzJE-4Zj-13@gated-at.bofh.it> <qVA30-5qa-19@gated-at.bofh.it> <qVAPp-65V-35@gated-at.bofh.it>
X-Enigmail-Draft-Status	N1110
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
X-Originating-IP	[192.168.167.68]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	<alsa-devel@alsa-project.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, James Hartley <james.hartley@imgtec.com>
X-Original-Date	Wed, 27 Jan 2016 17:13:09 +0000
X-Original-Message-ID	<56A8FAA5.1000907@imgtec.com>
X-Original-References	<1453818867-16322-1-git-send-email-Damien.Horsley@imgtec.com> <1453818867-16322-2-git-send-email-Damien.Horsley@imgtec.com> <20160127145756.GR6042@sirena.org.uk> <56A8DFBC.6070007@imgtec.com> <20160127160057.GA25316@sirena.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1319165

Show key headers only | View raw

On 27/01/16 16:00, Mark Brown wrote:
> On Wed, Jan 27, 2016 at 03:18:20PM +0000, Damien Horsley wrote:
>> On 27/01/16 14:57, Mark Brown wrote:
>>> On Tue, Jan 26, 2016 at 02:34:26PM +0000, Damien Horsley wrote:
> 
>>>> +  - clock-names : Includes the following entries:
>>>> +        "audio_pll"  The audio PLL
>>>> +        "i2s_mclk"   The i2s reference clock
>>>> +                     Also connected to i2s_out_0_mclk output
>>>> +        "dac_mclk"   Dac reference clock. Connected to i2s_dac_clk output
> 
>>> Why are these (especially the dac_mclk and i2s_mclk) properties of the
>>> card and not of the drivers for the respective devices?
> 
>> Due to the shared nature of these clocks. Individual components cannot
>> be responsible for controlling these as this could break configurations
>> for other components that are sharing the clocks. Only the card driver
>> has visibility of all of the components and their requirements.
> 
> You're talking about the code that decides what rates to set the clock
> at, not where the properties are placed in the DT.
> 
>> i2s_mclk and dac_mclk can be used by both the i2s in and i2s out paths
>> on some boards
> 
> Multiple devices can reference the same clock.
> 

audio_pll is referenced exclusively by the card device

i2s_mclk and dac_mclk can also be referenced by other devices. The i2s
out controller references i2s_mclk, and codec devices can reference
i2s_mclk/dac_mclk dependent on their system clock requirements

without a reference to i2s_mclk and dac_mclk in the card driver, it
would not be possible to control the divisors and gates for these clocks
in the following cases:

Simplistic codecs that do not have drivers

Codec drivers that do not call clk_set_rate and clk_enable/clk_disable

Thread

Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio  card Mark Brown <broonie@kernel.org> - 2016-01-27 16:00 +0100
  Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio  card Damien Horsley <Damien.Horsley@imgtec.com> - 2016-01-27 16:20 +0100
    Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio  card Mark Brown <broonie@kernel.org> - 2016-01-27 17:10 +0100
      Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio  card Damien Horsley <Damien.Horsley@imgtec.com> - 2016-01-27 18:20 +0100
        Re: [RFC V2 1/2] ASoC: img: Add binding document for Pistachio audio  card Mark Brown <broonie@kernel.org> - 2016-01-27 21:20 +0100

csiph-web